Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Old fork #16

Closed
Kerilk opened this issue Dec 8, 2016 · 4 comments
Closed

Old fork #16

Kerilk opened this issue Dec 8, 2016 · 4 comments

Comments

@Kerilk
Copy link

Kerilk commented Dec 8, 2016

Hello Dave,

last year I needed a simple/elegant genetic algorithm library in ruby for one of my student internship. I found yours to be the most adapted to what he needed to do. I still needed to change quite a bit of things in order to get it where I wanted. When I stopped I was not sure a pull request was really feasible anymore or my branch mature enough. More than 30% of the code has been rewritten.

I see that you have received contributions recently, which means that the two branches will diverge from now on. So I though maybe maybe you could be interested in the changes I did before they are irremediably unmergeable.

the fork can be found here:
https://github.com/Nanosim-LIG/darwinning

Don't hesitate if you have questions.

Best regards,

Brice

@dorkrawk
Copy link
Owner

Hey Brice,

I'm glad my library was useful for you. I'll take a look at your branch and see if there's anything that makes sense to pull in.

Thanks!

@dorkrawk
Copy link
Owner

Hey Brice,

I just got around to really digging through your the commits in your branch and there's some good stuff there. I've been just picking through a lot of the refactors and just implementing stuff myself but I'd like to give you credit for the work you did. How would you like me to do that?

@Kerilk
Copy link
Author

Kerilk commented Jan 31, 2017

Hello Dave,

I am sure a one liner at the end of the read me is enough. Don't hesitate to tell me if you don't feel it is appropriate. Thanks for taking the time to read the code.

@dorkrawk
Copy link
Owner

dorkrawk commented Feb 3, 2017

b6795c9

@dorkrawk dorkrawk closed this as completed Feb 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants