Output the stat data #126
Open
Output the stat data #126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lykahb
commented
Feb 22, 2022
| export async function listAllFilesAsAdded(): Promise<File[]> { | ||
| return core.group(`Listing all files tracked by git`, async () => { | ||
| const emptyTreeHash = (await exec('git', ['hash-object', '-t', 'tree', '/dev/null'])).stdout | ||
| return getGitDiffStatusNumstat(emptyTreeHash) |
There was a problem hiding this comment.
The git ls-files does not return the data about the number of lines added. Comparing the current revision to an empty tree both allows getting the stat data, and lets us reuse the existing diff logic.
| const matchingFilenamesList = Object.values(result).flatMap(filteredFiles => filteredFiles.map(file => file.filename)) | ||
| const matchingFilenamesSet = new Set(matchingFilenamesList) | ||
| result.other = files.filter(file => !matchingFilenamesSet.has(file.filename)) | ||
| } |
There was a problem hiding this comment.
If there already was a filter group named other, it won't be overwritten. If the config did not have it, adding a new non-declared group should be safe - the keys are not in JSON, so it is unlikely that there exists logic in a step that uses paths-filter output that discovers the keys rather than uses the hardcoded names.
lykahb
force-pushed
the
numstat
branch
3 times, most recently
from
1396714
to
81575a9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Getting more data about the changes that are grouped by path would unlock new ways to use this action.
My motivation is to get enough data to make a comment with changes broken down by the filter groups - see the example. Another usecase would be to have a condition that applies a label depending on the number of lines changed. For example, marking a PR with few changes in
srcas easy to review.There is a new output
{key}_statwith a JSON/CSV that has the numstat data, aggregated by the filter groups. In effect, the data is similar to what one would get by callinggit diff --shortstat <diff_refs> <list of filter globs>for each filter group.Here are the details:
FileNumstatandFileStatusand rename the existing functions that deal withgit diffto mention status.git diff --numstatfor all scenarios of getting the data from gitotherfor the files not matched by any filters. This is not related to the numstat changes but supports the usecase for commenting the breakdown of changes.The only observable change for the existing users should be the addition of a new group
other.