Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using "v1" still serves 1.9.0 instead of 1.9.1 #444

Closed
JojOatXGME opened this issue May 8, 2024 · 5 comments
Closed

Using "v1" still serves 1.9.0 instead of 1.9.1 #444

JojOatXGME opened this issue May 8, 2024 · 5 comments
Assignees
Labels
bug Something isn't working

Comments

@JojOatXGME
Copy link
Contributor

JojOatXGME commented May 8, 2024

Describe the bug

The following code block still uses version 1.9.0, although 1.9.1 has already been released.

      - name: Test Report
        uses: dorny/test-reporter@v1
        continue-on-error: true
        with:
          artifact: /test-results-([^-]*)-(.*)/
          name: "Unit Tests Report: Gradle $1 @ $2"
          path: "test-results/*/TEST-*.xml"
          reporter: java-junit
          fail-on-empty: false

Here is the link to my build:
https://github.com/JojOatXGME/gradle-grammar-kit-plugin/actions/runs/9009127375/job/24752722668
You can see the version which has been used by the build by looking into the “Set up job”-step.

Additional context

I noticed that this repository has both a branch and a tag called v1. The branch does not yet contain the new version. I guess the branch takes precedence. I also think the v1 tag is new and did not exist for earlier releases.

@JojOatXGME JojOatXGME added the bug Something isn't working label May 8, 2024
@jozefizso
Copy link
Collaborator

Yeah, I published a tag instead of merging the code into v1.

But as I see the new code may break the old clients, we need to fix that first.

@JojOatXGME
Copy link
Contributor Author

But as I see the new code may break the old clients, we need to fix that first.

Would be interesting to know what the issue is. Is it related to my changes at #438, or something else?

@JojOatXGME
Copy link
Contributor Author

JojOatXGME commented May 10, 2024

I just noticed that #363 (comment) initially mentioned an issue after trying it out. I guess this is the issue you meant? Looks like it is resolved now. 😄

@jozefizso
Copy link
Collaborator

I've fixed this, the branch v1 is now the same as v1.9.1 release.

@JojOatXGME
Copy link
Contributor Author

Thanks. I can confirm that it is working for me. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

5 participants