Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Supported shells are printed whenever Error: shell * is still not supported is printed #165

Open
magnus-ISU opened this issue Nov 22, 2021 · 1 comment

Comments

@magnus-ISU
Copy link

Even looking at the code, maybe its because I don't know Go really well but I can't figure out what is supported :P

It seems to me like the supported shells should be known at compile time. However, it is a map which shells are added to at runtime which confuses me.

I would like to try to add ion support, but am confused by what is going on.

magnus-ISU added a commit to magnus-ISU/antidot that referenced this issue Nov 22, 2021
@doron-cohen
Copy link
Owner

This was an overkill design choice looking back. I think I should just hold all shells in one global list. Next time I will get to that part in the code I will refactor.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants