Skip to content

Commit

Permalink
python310Packages.matplotlib: comments fixes
Browse files Browse the repository at this point in the history
The link to the build docs is outdated, and it doesn't have an updated
direct alternative. While I tried to enable at least some of the tests,
I encountered NixOS#255262 which is
now linked in a comment.
  • Loading branch information
doronbehar authored and veprbl committed Jan 11, 2024
1 parent e68cf14 commit eba8931
Showing 1 changed file with 4 additions and 3 deletions.
7 changes: 4 additions & 3 deletions pkgs/development/python-modules/matplotlib/default.nix
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@
, isPyPy
, pythonOlder

# https://github.com/matplotlib/matplotlib/blob/main/doc/devel/dependencies.rst
# build-system
, certifi
, pkg-config
Expand Down Expand Up @@ -182,8 +181,10 @@ buildPythonPackage rec {

env.MPLSETUPCFG = writeText "mplsetup.cfg" (lib.generators.toINI {} passthru.config);

# Matplotlib needs to be built against a specific version of freetype in
# order for all of the tests to pass.
# Encountering a ModuleNotFoundError, as describved and investigated at:
# https://github.com/NixOS/nixpkgs/issues/255262 . It could be that some of
# which may fail due to a freetype version that doesn't match the freetype
# version used by upstream.
doCheck = false;

meta = with lib; {
Expand Down

0 comments on commit eba8931

Please sign in to comment.