-
Notifications
You must be signed in to change notification settings - Fork 150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bonjour: skip browsing on tunnel interfaces #967
Conversation
With this change in this module and adding mobdev2_monitor=True to SideJITServer project i was able to run service without any hickups over wifi. Thanks for the quick response and changes to make this happen |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wait, if what u're saying is correct, than this error should be fixed in the browse()
method instead
Curious i will test that method tomorrow |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
as i understand this, we don't want to query tunX
device at all - meaning the change should be done when iterating get_adapters()
Thank you for your time @doronz88 it was obvious that you would have been able to make this change yourself easily, however not been able to test it in the wild, yet you left me to re-iterate the solutions. Thank you once more for a the mentoring. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We're almost there! :)
Please add this change to get_ipv4_addresses()
also so no bonjour browse will ever go through the tunX
interfaces
8870539
to
d47c3bf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did the required changes
this is a working solution fixing issue #966
which makes tunnel task creation to timeout , which causes fastapi to timeout as well for 2minutes straight in a loop.