Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bonjour: skip browsing on tunnel interfaces #967

Merged
merged 1 commit into from
May 2, 2024

Conversation

takov751
Copy link
Contributor

this is a working solution fixing issue #966
which makes tunnel task creation to timeout , which causes fastapi to timeout as well for 2minutes straight in a loop.

@takov751 takov751 changed the title Fix malformed ip address due to zeroconf packate over already establish tunnel. Skip malformed ip_address due to incoming zeroconf packet over already establish tunnel. Apr 28, 2024
@takov751
Copy link
Contributor Author

With this change in this module and adding mobdev2_monitor=True to SideJITServer project i was able to run service without any hickups over wifi. Thanks for the quick response and changes to make this happen

pymobiledevice3/lockdown.py Outdated Show resolved Hide resolved
pymobiledevice3/lockdown.py Outdated Show resolved Hide resolved
Copy link
Owner

@doronz88 doronz88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wait, if what u're saying is correct, than this error should be fixed in the browse() method instead

@takov751
Copy link
Contributor Author

Curious i will test that method tomorrow

@takov751 takov751 requested a review from doronz88 April 29, 2024 05:15
Copy link
Owner

@doronz88 doronz88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as i understand this, we don't want to query tunX device at all - meaning the change should be done when iterating get_adapters()

@takov751
Copy link
Contributor Author

Thank you for your time @doronz88 it was obvious that you would have been able to make this change yourself easily, however not been able to test it in the wild, yet you left me to re-iterate the solutions. Thank you once more for a the mentoring.

Copy link
Owner

@doronz88 doronz88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're almost there! :)
Please add this change to get_ipv4_addresses() also so no bonjour browse will ever go through the tunX interfaces

pymobiledevice3/bonjour.py Outdated Show resolved Hide resolved
pymobiledevice3/bonjour.py Outdated Show resolved Hide resolved
@doronz88 doronz88 force-pushed the master branch 2 times, most recently from 8870539 to d47c3bf Compare May 2, 2024 05:04
Copy link
Owner

@doronz88 doronz88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did the required changes

@doronz88 doronz88 changed the title Skip malformed ip_address due to incoming zeroconf packet over already establish tunnel. bonjour: skip browsing on tunnel interfaces May 2, 2024
@doronz88 doronz88 merged commit b1ab5fd into doronz88:master May 2, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants