Merge pull request #939 from dorssel/cache_and_pinning

Fix package pinning and caching

.github/workflows/build-installer.yml

@@ -31,12 +31,10 @@ jobs:
 
       - name: Setup .NET
         uses: actions/setup-dotnet@v4
-
-      - name: Cache
-        uses: actions/cache@v4
         with:
-          path: ~/.nuget/packages
-          key: ${{ runner.os }}-nuget-${{ hashFiles('**/Directory.Packages.props', '**/global.json') }}
+          # NOTE: caching seems to actually slow down the build, both on hit and on miss
+          cache: false
+          cache-dependency-path: '**/packages.lock.json'
 
       - name: Install dependencies
         run: dotnet restore

Directory.Build.props

@@ -18,13 +18,15 @@ SPDX-License-Identifier: GPL-3.0-only
     <!-- For PowerShell, we support everything -->
     <Platforms>AnyCPU</Platforms>
     <Platform>AnyCPU</Platform>
+    <RuntimeIdentifiers>win-x64;win-x86</RuntimeIdentifiers>
     <IsTrimmable>false</IsTrimmable>
   </PropertyGroup>
 
   <PropertyGroup Condition="$(TargetFramework) != 'netstandard2.0'">
     <!-- This product only supports x64 (the only architecture supported by VBoxUsb) -->
     <Platforms>x64</Platforms>
     <Platform>x64</Platform>
+    <RuntimeIdentifiers>win-x64</RuntimeIdentifiers>
     <IsTrimmable>true</IsTrimmable>
     <!--
     <IsAotCompatible>true</IsAotCompatible>
@@ -48,6 +50,10 @@ SPDX-License-Identifier: GPL-3.0-only
 
     <!-- Common defaults -->
     <ManagePackageVersionsCentrally>true</ManagePackageVersionsCentrally>
+    <CentralPackageTransitivePinningEnabled>true</CentralPackageTransitivePinningEnabled>
+    <RestorePackagesWithLockFile>true</RestorePackagesWithLockFile>
+    <RestoreLockedMode Condition="'$(GITHUB_ACTIONS)' == 'true'">true</RestoreLockedMode>
+    <ContinuousIntegrationBuild Condition="'$(GITHUB_ACTIONS)' == 'true'">true</ContinuousIntegrationBuild>
     <InvariantGlobalization>true</InvariantGlobalization>
     <SelfContained>false</SelfContained>
     <IsPackable>false</IsPackable>

Installer/packages.lock.json

@@ -0,0 +1,32 @@
+{
+  "version": 2,
+  "dependencies": {
+    "native,Version=v0.0": {
+      "GitVersion.MsBuild": {
+        "type": "Direct",
+        "requested": "[5.12.0, )",
+        "resolved": "5.12.0",
+        "contentHash": "dJuigXycpJNOiLT9or7mkHSkGFHgGW3/p6cNNYEKZBa7Hhp1FdX/cvqYWWYhRLpfoZOedeA7aRbYiOB3vW/dvA=="
+      },
+      "WixToolset.Firewall.wixext": {
+        "type": "Direct",
+        "requested": "[5.0.0, )",
+        "resolved": "5.0.0",
+        "contentHash": "ImdAKuoOkZcqPiIXmrcprM8Y1azA17EXZdUecpDD/V5jJcY+Ir4EtRLIWjYNno8FgUXRFyFskmAV13Us2SIInA=="
+      },
+      "WixToolset.UI.wixext": {
+        "type": "Direct",
+        "requested": "[5.0.0, )",
+        "resolved": "5.0.0",
+        "contentHash": "bSXUeHrfylVOeoklBb3mSlmMmiIVmQnEakCLeEtQoUundgWY3LOlVr7yjLu/3RBkMCiYdGmaNhg7MHwS2iQDsA=="
+      },
+      "WixToolset.Util.wixext": {
+        "type": "Direct",
+        "requested": "[5.0.0, )",
+        "resolved": "5.0.0",
+        "contentHash": "7lLwyrf+2cTuPju0swTWtRNYesnOMxXhGugMnGGNEPDB4g/+BCUsub2RDYAxnBnbnND7QmPwZnneLrTIQOdAbg=="
+      }
+    },
+    "native,Version=v0.0/win-x64": {}
+  }
+}

Installer/packages.lock.json.license

@@ -0,0 +1,3 @@
+SPDX-FileCopyrightText: 2024 Frans van Dorsselaer
+
+SPDX-License-Identifier: GPL-3.0-only