Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move attach command to top level #778

Merged
merged 1 commit into from
Nov 23, 2023
Merged

Move attach command to top level #778

merged 1 commit into from
Nov 23, 2023

Conversation

dorssel
Copy link
Owner

@dorssel dorssel commented Nov 23, 2023

  • move 'wsl attach' to 'attach --wsl'
  • mark 'wsl' as obsolete
  • remove "bind if required and admin" from attach

Copy link
Contributor

github-actions bot commented Nov 23, 2023

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ ACTION actionlint 8 0 0.03s
✅ BASH bash-exec 1 0 0.0s
✅ BASH shellcheck 1 0 0.07s
✅ BASH shfmt 1 0 0.0s
✅ EDITORCONFIG editorconfig-checker 134 0 1.05s
✅ JSON eslint-plugin-jsonc 4 0 0.9s
✅ JSON jsonlint 4 0 0.2s
✅ JSON prettier 4 0 0.46s
✅ JSON v8r 4 0 3.06s
✅ MARKDOWN markdownlint 2 0 0.46s
✅ MARKDOWN markdown-link-check 2 0 5.31s
✅ MARKDOWN markdown-table-formatter 2 0 0.25s
✅ REPOSITORY checkov yes no 10.78s
✅ REPOSITORY gitleaks yes no 1.58s
✅ REPOSITORY git_diff yes no 0.03s
✅ REPOSITORY grype yes no 13.43s
✅ REPOSITORY secretlint yes no 0.94s
✅ REPOSITORY trivy yes no 5.18s
✅ REPOSITORY trivy-sbom yes no 3.7s
✅ REPOSITORY trufflehog yes no 4.83s
✅ XML xmllint 14 0 0.01s
✅ YAML prettier 13 0 1.04s
✅ YAML v8r 13 0 9.75s
✅ YAML yamllint 13 0 0.46s

See detailed report in MegaLinter reports

MegaLinter is graciously provided by OX Security

Copy link
Contributor

github-actions bot commented Nov 23, 2023

Test Results

2 729 tests  ±0   2 729 ✔️ ±0   7s ⏱️ ±0s
       1 suites ±0          0 💤 ±0 
       1 files   ±0          0 ±0 

Results for commit e4388f5. ± Comparison against base commit 94d6f88.

This pull request removes 18 and adds 18 tests. Note that renamed tests count towards both.
UnitTests.Parse_wsl_Tests ‑ Success
UnitTests.Parse_wsl_Tests ‑ UnknownCommand
UnitTests.Parse_wsl_attach_Tests ‑ BusIdAndHardwareId
UnitTests.Parse_wsl_attach_Tests ‑ BusIdArgumentInvalid
UnitTests.Parse_wsl_attach_Tests ‑ BusIdArgumentMissing
UnitTests.Parse_wsl_attach_Tests ‑ BusIdCanceled
UnitTests.Parse_wsl_attach_Tests ‑ BusIdFailure
UnitTests.Parse_wsl_attach_Tests ‑ BusIdSuccess
UnitTests.Parse_wsl_attach_Tests ‑ BusIdSuccessWithAutoAttach
UnitTests.Parse_wsl_attach_Tests ‑ BusIdSuccessWithDistribution
…
UnitTests.Parse_attach_Tests ‑ BusIdAndHardwareId
UnitTests.Parse_attach_Tests ‑ BusIdArgumentInvalid
UnitTests.Parse_attach_Tests ‑ BusIdArgumentMissing
UnitTests.Parse_attach_Tests ‑ BusIdCanceled
UnitTests.Parse_attach_Tests ‑ BusIdFailure
UnitTests.Parse_attach_Tests ‑ BusIdSuccess
UnitTests.Parse_attach_Tests ‑ BusIdSuccessWithAutoAttach
UnitTests.Parse_attach_Tests ‑ BusIdSuccessWithDistribution
UnitTests.Parse_attach_Tests ‑ DeviceMissing
UnitTests.Parse_attach_Tests ‑ HardwareIdArgumentInvalid
…

♻️ This comment has been updated with latest results.

- move 'wsl attach' to 'attach --wsl'
- mark 'wsl' as obsolete
- remove "bind if required and admin" from attach
@dorssel dorssel marked this pull request as ready for review November 23, 2023 19:51
@dorssel dorssel merged commit ff5aab1 into master Nov 23, 2023
8 checks passed
@dorssel dorssel deleted the attach branch November 23, 2023 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant