Moved grid_signals from environment to controllers #175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
birnbaum
approved these changes
Feb 6, 2024
examples/basic_example.py
Outdated
| ci_signal = HistoricalSignal(load_carbon_data()) | ||
| solar_signal = HistoricalSignal(load_solar_data(sqm=0.4 * 0.5)) | ||
|
|
||
| monitor = Monitor(grid_signals={"carbon_intensity": ci_signal}) # stores simulation result on each step |
There was a problem hiding this comment.
let's not pass any grid_signals to the Monitor in out examples. It yields no benefit to read them from the CSV-based signal just to write them to another CSV. But let's keep the feature, it might be useful in the future if we have live signals
There was a problem hiding this comment.
Agreed, but I will leave that in for the controller_example because we actually do something with the carbon data there, and it would be useful to see the intensity reflected in the output file (especially later for visualizing)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The grid signals from the environment were just passed around a couple of times throughout different classes, but only the controllers actually use them.
Now they are just initialized with them and there is no more unnecessary and complicated passing of these arguments, saving some complexity.