Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

environment.add_microgrid() is now the only way to create new microgrids #176

Merged
merged 1 commit into from Feb 15, 2024
Merged

environment.add_microgrid() is now the only way to create new microgrids #176

merged 1 commit into from Feb 15, 2024

Conversation

birnbaum
Copy link
Collaborator

@birnbaum birnbaum commented Feb 8, 2024

Got rid of microgrid.initialize()

marvin-steinke
marvin-steinke approved these changes Feb 8, 2024
View reviewed changes
Copy link
Contributor

@marvin-steinke marvin-steinke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good design decision. As we do not intend for the user to do something with the Microgrid, this solution removes complexity.

@birnbaum birnbaum merged commit 5902fef into main Feb 15, 2024
4 checks passed
@birnbaum birnbaum deleted the simplified-microgrid-creation branch February 19, 2024 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marvin-steinke marvin-steinke marvin-steinke approved these changes

@kilianp14 kilianp14 kilianp14 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@birnbaum @marvin-steinke @kilianp14