Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mistakes in switching to ansi text codes #2017

Merged
merged 2 commits into from Oct 13, 2022
Merged

Conversation

rderooy
Copy link
Collaborator

@rderooy rderooy commented Oct 11, 2022

This commit will...

@kcgen
Copy link
Member

kcgen commented Oct 11, 2022

You're on a roll, @rderooy !

I did a bad job explaining the commit messages (sorry!).

The wording is important for git commits (different from the GitHub PR wording, which encompasses a group of one or more commits).

It's the commits (individually) that are added to the git repository, (not the PR wording). The git commits are agnostic of the web-hosting front-end (like GitHub). For example, if we moved to from GitHub to GitLab (or something else), the commit messages will be retained.

The "This commit will..." is a trick I use to see if my own commit messages are worded right; it applies perfectly to your first commit but not the second commit:

2022-10-11_12-43

(if you can rename the second, that'd be perfect 🍻 )

Just as an example, here's the running short-log from my command-line:

2022-10-11_13-54

@kcgen kcgen added the translation Issues related to translations label Oct 11, 2022
@kcgen
Copy link
Member

kcgen commented Oct 12, 2022

(@rderooy - sorry for the long winded explanation 😅) this is all set to merge, if you can rename the ran update_sources.sh commit to Sync English message sources

@rderooy
Copy link
Collaborator Author

rderooy commented Oct 12, 2022

@kcgen I did not have the time to take care of this yesterday. It is on my todo list for when I get home this evening.

@kcgen
Copy link
Member

kcgen commented Oct 12, 2022

@kcgen I did not have the time to take care of this yesterday. It is on my todo list for when I get home this evening.

roger that, and zero rush 👍

@kcgen kcgen merged commit e729eb6 into main Oct 13, 2022
@rderooy rderooy deleted the rdr/fixup-mistakes-1 branch October 13, 2022 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
translation Issues related to translations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants