Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Look for libXInput dependency #2085

Merged
merged 2 commits into from
Nov 17, 2022
Merged

Look for libXInput dependency #2085

merged 2 commits into from
Nov 17, 2022

Conversation

dreamer
Copy link
Member

@dreamer dreamer commented Nov 16, 2022

It's a ManyMouse library dependency - at least on non-Windows, non-macOS systems. If package is not installed then build fails with:

../src/libs/manymouse/x11_xinput2.c:31:10: fatal error: X11/extensions/XInput2.h: No such file or directory
31 | #include <X11/extensions/XInput2.h>
| ^~~~~~~~~~~~~~~~~~~~~~~~~~
compilation terminated.

Also, add iir1-devel package to instructions for Fedora users, as the package is available.

@dreamer dreamer requested a review from kcgen November 16, 2022 21:11
@dreamer dreamer self-assigned this Nov 16, 2022
@dreamer dreamer added the build system Build system related issues label Nov 16, 2022
meson.build Outdated Show resolved Hide resolved
@kcgen
Copy link
Member

kcgen commented Nov 16, 2022

Thanks @dreamer!
Looks good - just one possible suggestion.

ManyMouse lib depends on XInput2.h for non-Windows, non-macOS builds.
It seems to not cause issues on Ubuntu (perhaps dependency is pulled by
some other package), but leads to compilation error on Fedora.
@kcgen
Copy link
Member

kcgen commented Nov 17, 2022

One of Glib's subprojects is failing to setup due to git not being able to fetch the repo (more intermittent gnome GitLab outages):

2022-11-17_12-02

This is a separate issue and not related to this PR, so merging.

@kcgen kcgen merged commit 34d581c into main Nov 17, 2022
@pr-triage pr-triage bot added the PR: merged label Nov 17, 2022
@delete-merged-branch delete-merged-branch bot deleted the po/libxi-dependency branch November 17, 2022 20:04
@kcgen kcgen removed the PR: merged label Jan 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build system Build system related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants