Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Earthworm Jim graphical errors on left screen border #2510

Closed
3 tasks done
Burrito78 opened this issue May 22, 2023 · 1 comment · Fixed by #2528
Closed
3 tasks done

Earthworm Jim graphical errors on left screen border #2510

Burrito78 opened this issue May 22, 2023 · 1 comment · Fixed by #2528
Labels
bug Something isn't working

Comments

@Burrito78
Copy link
Collaborator

Are you using the latest Dosbox-Staging Version?

  • I have checked releases and am using the latest release.

Different version than latest?

DEV

What Operating System are you using?

Mac OS

If Other OS, please describe

No response

Relevant hardware info

No response

Have you checked that no other similar issue already exists?

  • I have searched and not found similar issues.

A clear and concise description of what the bug is.

At the start of the first level, when you move the character there are parts of the backround that flicker on the left screen border.

Error does happen using v0.80.1 and latest dev build.
Error also happens in vanilla DOSBox v0.74-3.

Couldn't reproduce the error using DOSBox-X (May release).

Steps to reproduce the behaviour.

Explain how to reproduce

  1. Start Earthworm Jim (i used the eXoDOS version) after mounting the CD image.
  2. Select option '1' for mixed resolutions (320x224 and 320x240 (recommended)).
  3. You can skip the intro by pressing ESC once.
  4. Start the game which brings you to the first level.

-The error doesn't always happen, try starting only the game again from the DOS CLI is enough to reproduce the problem.
-Performance also takes a huge hit when the error happens.

Log output about resolution switching with latest main:
Bildschirmfoto 2023-05-22 um 11 02 58

Video capture of the problem:
ewj1_000.avi.zip

Download URL of affected game or software

No response

Your configuration

No response

Provide a Log

No response

Code of Conduct & Contributing Guidelines

  • Yes, I agree.
@Burrito78 Burrito78 added the bug Something isn't working label May 22, 2023
@Kappa971
Copy link
Contributor

This game runs at an odd resolution and refresh rate (320x224 72Hz reported as 640x448 in game, 320x240 60Hz reported as 640x480 in the menu).
With my old 60Hz FullHD monitor I also noticed this strange artifact, I don't remember what I did to remove it. However, I remember that to play it smoothly, before starting the game, I set the screen to 800x600 72Hz (The screen supported this mode).
To play this game I recommend any FreeSync monitor, even the cheapest 75Hz monitor (which I don't recommend for modern games as they don't support LFC).

kcgen added a commit that referenced this issue May 24, 2023
@kcgen
Effect the VGA resize within half the current frame-time (#2510)
6bda815
kcgen added a commit that referenced this issue May 24, 2023
@kcgen
Resize VGA within half the current frame-time (#2510)
d88230b
@kcgen kcgen mentioned this issue May 24, 2023
Merged
kcgen added a commit that referenced this issue May 24, 2023
@kcgen
Resize VGA within half the current frame-time (#2510)
b68b66f
johnnovak added a commit that referenced this issue Jun 25, 2023
@johnnovak
Always recalculate the display dimensions when the Maximum Scan Line …
e7c596b 
…Register changes

Because the timeout for recalculating the display dimensions was reduced
from 50m to half-frame time in commit b68b66f to fix some visual
glitches in a few games ("Resize VGA within half the current frame-time
(#2510)"), now other games don't always get the "full state" of the VGA
registers when the recalculation hits on slower cycles settings.

The obvious solution (while leaving the mentioned fix intact) is to
force the recalculation whenever affected register values change instead
of relying the timeout in the hope that's it waits long enough.

Clearly, this is a limitation of the "lazy VGA register" evaluation
mechanism for mode changes.
@Grounded0 Grounded0 mentioned this issue Nov 17, 2023
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Resize VGA within half the current frame-time (#2510) dosbox-staging/dosbox-staging
2 participants
@Burrito78 @Kappa971