Use vcpkg from its repository
#1175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kcgen
added
CI
kcgen
changed the title
vcpkg direct from the repositoryvcpkg from its repository
kcgen
force-pushed
the
kc/git-update-vcpkg-1
branch
from
fda333d
to
76d10f7
Compare
kcgen
force-pushed
the
kc/git-update-vcpkg-1
branch
from
76d10f7
to
eadd96c
Compare
|
Putting vcpkg back in business using an older known-good commit (microsoft/vcpkg@4b317d7) until the latest is fixed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Last week a bug was introduced in vcpkg that prevented it from building
gettext, an indirect dependency of Staging by way ofglib, which FluidSynth depends on.The vcpkg team is working on a PR to fix it: microsoft/vcpkg#19361.
Because this is impacting innumerable Windows build chains, we expect the vcpkg team to merge their fix shortly. However, because GitHub's VM team takes weekly snapshots of vcpkg, our CI workflows won't actually benefit from the gettext fix until sometime Sunday or Monday, which is when GitHub will update their VM images.
In the meantime, we can use vcpkg directly from its repository (with this PR) as soon as they merge the fix for
gettext.(Parking this as a draft for now)