Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resume using GitHub's built-in vcpkg instead of work-around from repo #1201

Merged
merged 2 commits into from
Aug 16, 2021

Conversation

kcgen
Copy link
Member

@kcgen kcgen commented Aug 14, 2021

A couple weeks ago GitHub's built-in vcpkg was in a broken state, which consequently broke our Windows CI workflow. Staging implemented a work-around to replace it with a prior known-good version. The PR will rollback our work around (when we confirm vcpkg is working properly again).

@kcgen kcgen self-assigned this Aug 14, 2021
@kcgen kcgen added backport Important fixes that should be backported CI GitHub Actions / CI related issues labels Aug 14, 2021
@kcgen
Copy link
Member Author

kcgen commented Aug 14, 2021

Still broken in the current GitHub CI VMs. Will check it again after the Sunday (when VMs are updated).

@kcgen
Copy link
Member Author

kcgen commented Aug 16, 2021

The VMs have rolled over and workflows from this branch are now running clean. Going ahead with the merge.

@kcgen kcgen merged commit 10d01ea into master Aug 16, 2021
@kcgen kcgen deleted the kc/revert-vcpkg-from-repo-1 branch August 17, 2021 15:46
@kcgen kcgen added this to the 0.78 release milestone Dec 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Important fixes that should be backported CI GitHub Actions / CI related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant