-
-
Notifications
You must be signed in to change notification settings - Fork 150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement MORE.COM command #2020
Conversation
c660d66
to
aae17fc
Compare
d48a3af
to
89fa10b
Compare
As discussed on Discord - some extensions from #1556 should be included in the implementation. Converting to draft for now. |
No comments; code is very readable and testing are running nicely. @FeralChild64 , if you can rebase against #include "fs_utils.h"
// MORE's FILENAME as non-null char*, std::string, or std_fs::path
// (no filesystem checks needed, get_lines will do it)
const auto text_file = ...
const auto lines = get_lines(text_file);
if (!lines)
// the file could not be read, bail out
// iterate over zero or more std::string lines
for (const auto & line : *lines) {
...
} |
A mistake: COMMAND is the command to diplay output one screen at a time. |
f744684
to
156c385
Compare
a8158c4
to
8f9c8ed
Compare
8f9c8ed
to
115ff7a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great @FeralChild64. A couple very minor comments.
Approved; feel free to merge when ready.
@kcgen It's still a draft. I haven't tested everything, and the FreeDOS multi-file viewing is not yet implemented (I'll have to be careful here to not break the visual side). I'll mark it as 'Ready for review' and re-request the review when I'm done - hard to tell precisely what changes I'll do. |
6f2de57
to
6a0e559
Compare
6a0e559
to
97ae8de
Compare
97ae8de
to
d32b60a
Compare
All comments addressed 🚀 |
Added MORE.COM command native implementation - available on drive Z:
Supports MS-DOS 7.0 (Windows 95) and FreeDOS extensions. I have tried to make the output as user friendly as possible.
Note that some wild ANSI escape sequences (like cursor movements) might disrupt the output - it would be really hard to make MORE.COM fully resistant.
Some files I used for testing: testfiles.tar.gz