Clamp the max Sound Blaster 16 sample rate to 45454 Hz, not 45000 Hz #2676
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
45454 Hz is the native DAC rate and thus the highest achievable sample rate on the SB16, and many programs use that rate. Clamping to 45000 Hz would result in a slightly lower pitch in such programs. The official programming guide is simply wrong when it states the following: "Valid output rates range from 5000 to 45 000 Hz, inclusive."
johnnovak
added
audio
FeralChild64
approved these changes
Jul 12, 2023
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
45454 Hz is the native DAC rate and thus the highest achievable sample rate on the SB16, and many programs use that rate. Clamping to 45000 Hz would result in a slightly lower pitch in such programs.
The official programming guide is simply wrong when it states the following:
"Valid output rates range from 5000 to 45 000 Hz, inclusive."
This was a quite obscure regression; see this thread for details on how I ran into it:
https://www.vogons.org/viewtopic.php?f=62&t=88524