Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compatibility problems with VBADOS (VBMOUSE.EXE) mouse driver #2742

Merged
merged 2 commits into from
Aug 12, 2023

Conversation

FeralChild64
Copy link
Collaborator

@FeralChild64 FeralChild64 commented Aug 9, 2023

  • fixed PS/2 packet data loss problems when BIOS was receiving the next packet before the previous one was fully retrieved (due to this problem VBMOUSE.EXE was completely broken if emulated PS/2 mouse supported wheel)
  • prevented unnecessary dummy mouse events in VMware mouse protocol
  • added support for PS/2 mouse packet size 1 to the BIOS - VBADOS seems to prefer it
  • silenced warning in our internal DOS driver, which was a result of VBADOS checking if it is already installed

Driver link: https://git.javispedro.com/cgit/vbados.git/about/ (changes are related to VBMOUSE.EXE DOS driver, not to the Windows driver)

@FeralChild64 FeralChild64 added the bug Something isn't working label Aug 9, 2023
@FeralChild64 FeralChild64 self-assigned this Aug 9, 2023
@FeralChild64 FeralChild64 changed the title [Work-In-Progress] Fix PS/2 wheel mouse BIOS incompatibility with VBADOS mouse driver Fix compatibility problems with VBADOS mouse driver Aug 10, 2023
@FeralChild64 FeralChild64 changed the title Fix compatibility problems with VBADOS mouse driver Fix compatibility problems with VBADOS (VBMOUSE.EXE) mouse driver Aug 10, 2023
@FeralChild64 FeralChild64 added the enhancement New feature or enhancement of existing features label Aug 10, 2023
@FeralChild64 FeralChild64 marked this pull request as ready for review August 10, 2023 13:31
@FeralChild64 FeralChild64 added regression We broke something 😊 and removed enhancement New feature or enhancement of existing features labels Aug 10, 2023
Copy link
Member

@johnnovak johnnovak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one minor comment @FeralChild64 , nice work as always 👍🏻

@FeralChild64 FeralChild64 merged commit e0f67e0 into main Aug 12, 2023
50 checks passed
@FeralChild64 FeralChild64 deleted the fc/mouse-bios-fix-1 branch August 12, 2023 20:58
@johnnovak johnnovak added the input handling Issues related to handling any input (keyboard, mouse, joystick & game controllers) label Dec 11, 2023
@Torinde
Copy link
Contributor

Torinde commented Dec 23, 2023

Tested that - it worked for me. Thanks!

Can it be made even more seamless? #3290

@Grounded0
Copy link
Collaborator

Hint for anyone who wants to use this but doesn't want to deal with compatibility problems that might occur by keeping this loaded outside of Windows 3.1x:

$ cat WIN.BAT
config -set cputype=pentium_slow
c:\vbados\vbmouse.exe
win.com
c:\vbados\vbmouse.exe uninstall
config -set cputype=auto

@FeralChild64
Copy link
Collaborator Author

This driver is mainly useful if booting real MS-DOS. We already provide what is needed for the Windows INT33 driver.

@Grounded0
Copy link
Collaborator

Grounded0 commented Dec 30, 2023

I have a little bit of a problem when working with MS-DOS Prompt inside Windows 3.1x. Mainly tracking and mouse click registration problems. When VBMOUSE.EXE is loaded its smooth sailing even with MS-DOS Prompt running.

Is VBMOUSE.EXE only required if you use MS-DOS Prompt inside Windows 3.1x? It could be that i have something wrongly configured or does loading the FreeDOS COMMAND.COM cause problems. The running process in the status line changes from KRNL386 to COMMAND when i'm running MS-DOS Prompt.

Can you personally notice this, is this expected behaviour or should i file a ticket about it?

@FeralChild64
Copy link
Collaborator Author

@Grounded0 I can see the mouse does nit behave correctly within MS-DOS Prompt window, but I think it would be a good idea to have an issue for this.

@Grounded0 Grounded0 added the Windows 3.x Issues related to Windows 3.x compatibility label Jun 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working input handling Issues related to handling any input (keyboard, mouse, joystick & game controllers) regression We broke something 😊 Windows 3.x Issues related to Windows 3.x compatibility
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants