Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix coverity sign extension warning #3001

Merged
merged 1 commit into from
Oct 14, 2023
Merged

Fix coverity sign extension warning #3001

merged 1 commit into from
Oct 14, 2023

Conversation

weirddan455
Copy link
Collaborator

Description

Again, not sure how to test that this actually fixes the warning without pushing to main but I think this one is pretty straight forward.

Related issues

#2996

Manual testing

It builds.

Checklist

Please tick the items as you have addressed them. Don't remove items; leave the ones that are not applicable unchecked.

I have:

  • followed the project's contributing guidelines and code of conduct.
  • performed a self-review of my code.
  • commented on the particularly hard-to-understand areas of my code.
  • split my work into well-defined, bisectable commits, and I named my commits well.
  • applied the appropriate labels (bug, enhancement, refactoring, documentation, etc.)
  • checked that all my commits can be built.
  • confirmed that my code does not cause performance regressions (e.g., by running the Quake benchmark).
  • added unit tests where applicable to prove the correctness of my code and to avoid future regressions.
  • made corresponding changes to the documentation or the website according to the documentation guidelines.
  • locally verified my website or documentation changes.

@weirddan455 weirddan455 added the plumbing Issues related to low-level support functions and classes label Oct 14, 2023
@weirddan455 weirddan455 self-assigned this Oct 14, 2023
Copy link
Member

@kcgen kcgen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice fix, @weirddan455 !

@kcgen kcgen merged commit 723c64f into main Oct 14, 2023
50 checks passed
@kcgen kcgen deleted the wd/sign-ext branch October 14, 2023 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
plumbing Issues related to low-level support functions and classes
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants