-
-
Notifications
You must be signed in to change notification settings - Fork 149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Paginate the CONFIG command's output #3758
Conversation
dbf1e1f
to
adc6003
Compare
f05e682
to
7c597a6
Compare
31524de
to
09f1d3a
Compare
7c9cb31
to
0a03dab
Compare
Most likely the https://github.com/dosbox-staging/dosbox-staging/blob/jn/paginate-config-output/contrib/resources/translations/README.md file needs a small update. It claims:
If I understand correctly, the implementation is now done (but I won't have time to test it today). |
Thanks @FeralChild64, I'll take care of these two issues you mentioned in this PR. They seem simple enough. |
99ed87f
to
a201edb
Compare
@FeralChild64 80 char long lines are fine now, so I've updated the translation guide. Only the Raised a ticket for it: #3769 |
That's perfectly fine - this is a minor issue, and not a regression. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This all looks good to me.
Description
As the title says. Displaying our built-in command's help with the
/?
or-h
options does that already, so I've taughtCONFIG
the same trick.It really bothered me that I had to make people type in things like
CONFIG -h glshader | MORE
in the getting started guide. Plus having to pipe things throughMORE
manually is just an annoyance for everybody.I've also some made some further enhancements to the output (inserting some new lines here and there).
This fixes the PVS-Studio warnings too that I somehow introduced to
main
...Manual testing
Played around with the relevant
CONFIG
commands, and confirmed the output is now paginated.Checklist
Please tick the items as you have addressed them. Don't remove items; leave the ones that are not applicable unchecked.
I have: