Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix middlegame mouse control and improve corresponding error messaging #563

Closed
wants to merge 2 commits into from

Conversation

kcgen
Copy link
Member

@kcgen kcgen commented Aug 20, 2020

The middlegame mouse control was not taking effect; thanks to @arrowgent for reporting this regression.

This PR also improves the error messaging when the the mouse control settings are missing or incorrect, also suggested by @arrowgent. See commit comment for new output: 4aece2e

Will await feedback to see if this addresses the points here: 4aece2e

(Tested on Linux)

@kcgen kcgen self-assigned this Aug 20, 2020
@kcgen kcgen added the bug Something isn't working label Aug 20, 2020
@kcgen kcgen requested a review from dreamer August 20, 2020 19:20
Copy link
Member

@dreamer dreamer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested it and implementation is ok; it's also small and clean, so perfect :)

@kcgen Please adjust the commit messages for both commits this way:

  • First commit: fix type nane -> name (also commit subject seems weird…)
  • Second commit: we don't have a bug report to refer to in second commit (creating one at this point would be silly). Please explain in commit message body the effect accomplished by this change. I will definitely want to include this in release notes for 0.76.0, but hunting down what was fixed by exact commit will be pretty annoying.

After commit messages will be adjusted, I'll merge it right away.

@arrowgent Thank you for the report and pointing out the issue :) Next time don't hesitate to create a new bug report - it's easier for us in the long term.

Before this fixm the middle mouse button wasn't being passed
through to the game and instead operated equivalently to
middlerelease.
@kcgen
Copy link
Member Author

kcgen commented Aug 22, 2020

@dreamer , thanks for flagging both of these poorly worded commits. Hopefully the updates describe them clearly.

Was it too early, too late, not enough tea? I'm out of excuses -- a good reminder for myself to always make a second review pass!

@dreamer
Copy link
Member

dreamer commented Aug 22, 2020

Found one more typo, but this time the fix was obvious ;) Merged in: 66e56da

@kcgen Thanks for clean fix! @arrowgent thank you for the report :)

@dreamer dreamer closed this Aug 22, 2020
@kcgen kcgen deleted the kc/fix-middle-game-1 branch August 22, 2020 23:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants