Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix space removing in modem ATD command #652

Merged
merged 1 commit into from Oct 9, 2020
Merged

Fix space removing in modem ATD command #652

merged 1 commit into from Oct 9, 2020

Conversation

NicknineTheEagle
Copy link
Member

This snippet removing trailing spaces from ATD command line was not actually working.

@kcgen
Copy link
Member

kcgen commented Oct 7, 2020

@NicknineTheEagle , can you show examples inside dosbox and/or a terminal program how this problematic code currently behaves versus how it should behave (perhaps with output from this PR)?

@NicknineTheEagle
Copy link
Member Author

NicknineTheEagle commented Oct 8, 2020

Easy to check, just open any terminal program type in "atdt bbs.dmine.net " (three trailing spaces). Right now, you'll get this:

SERIAL: Port 1 command sent to modem: ->ATDT BBS.DMINE.NET   <-
SERIAL: Port 1 connecting to host BBS.DMINE.NET    port 23.
SERIAL: Port 1 failed to connect.

With the fix, trailing spaces will get trimmed and the argument will get parsed properly:

SERIAL: Port 1 command sent to modem: ->ATDT BBS.DMINE.NET   <-
SERIAL: Port 1 connecting to host BBS.DMINE.NET port 23.
SERIAL: Port 1 modem response: CONNECT 57600.

@dreamer dreamer added the bug Something isn't working label Oct 8, 2020
Copy link
Member

@dreamer dreamer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@NicknineTheEagle trimming this way is even better :)

Thank you!

@dreamer dreamer merged commit a01ac05 into dosbox-staging:master Oct 9, 2020
@dreamer dreamer added this to Done in 0.76.0 release Oct 24, 2020
@dreamer dreamer added this to Done in 0.75.2 release Oct 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants