Reduce memory v2 #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By using mmap, we avoid allocating the entire FAT table, and we make it possible for the OS to read in pages from the disk on demand only. This option is only available in combination with -w, because any write to the mmapped region may be written to disk at any time. See also https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=771091 Limitations and possible improvements: - Don't know if mmap is available with DJGPP. - mmap could be used unconditionally if -w is given. - The conditional handling could be moved to fs_read/fs_write. - The same change would be useful in fatlabel and mkfs.fat.
This allows to override the automatic -f when -a is selected.
zuber147
added a commit
to zuber147/dosfstools
that referenced
this pull request
Oct 5, 2020
C program to find the greatest of two numbers
schmurtzm
added a commit
to OnionUI/Onion
that referenced
this pull request
Jun 15, 2023
New: - Add check disk step, important to avoid SD card FAT file system corruption. Fixes: - SD card mount point has changed on last firmware : fix available space on SD card. - Don't resume OTA app after a forced reboot. Issues : - fsck.fat is based on last release for best compatbility. However it uses a lot of memory and could crash on big SD card. This PR is quite old but could improve this behaviour : dosfstools/dosfstools#2
github-merge-queue bot
pushed a commit
to OnionUI/Onion
that referenced
this pull request
Jun 15, 2023
New: - Add check disk step, important to avoid SD card FAT file system corruption. Fixes: - SD card mount point has changed on last firmware : fix available space on SD card. - Don't resume OTA app after a forced reboot. Issues : - fsck.fat is based on last release for best compatbility. However it uses a lot of memory and could crash on big SD card. This PR is quite old but could improve this behaviour : dosfstools/dosfstools#2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes in v2:
total_cluster_bytes*sizeof(uint32_t), so I had to bypass that.fs->fatwhen read_fat is called a second time.