Use window.navigator.language if no language cookie is set. #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`cookieStore` always evaluates to `true` if `persistSelection` is `true` and `$injector.has('$cookieStore')`. This means that ngLocalize will not use a user's default language. Instead, it will just default to the `defaultLocale`. In my opinion, this is not the desired behavior.
| @@ -262,7 +262,7 @@ angular.module('ngLocalize') | |||
| return currentLocale; | |||
| } | |||
|
|
|||
| setLocale(cookieStore ? cookieStore.get(localeConf.cookieName) : $window.navigator.userLanguage || $window.navigator.language); | |||
| setLocale(cookieStore.get(localeConf.cookieName) ? cookieStore.get(localeConf.cookieName) : $window.navigator.userLanguage || $window.navigator.language); | |||
There was a problem hiding this comment.
setLocale(cookieStore && cookieStore.get(localeConf.cookieName) ? /* ... */);There was a problem hiding this comment.
How would cookieStore evaluate to false and cookieStore.get(localeConf.cookieName) evaluate to true? If cookieStore is false then cookieStore.get(localeConf.cookieName) will definitely be false as well. Seems like an unnecessary check. Am I overlooking something?
There was a problem hiding this comment.
If cookieStore doesn't exist, referencing cookieStore.get will cause an error
There was a problem hiding this comment.
Ah okay. Better safe than sorry! Thanks!
Attempt at fixing failing test.
doshprompt
added a commit
that referenced
this pull request
Jul 23, 2015
fix(locale): use window.navigator.language if no language cookie is set.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cookieStorealways evaluates totrueifpersistSelectionistrueand$injector.has('$cookieStore'). This means that ngLocalize will not use a user's default language. Instead, it will just default to thedefaultLocale. In my opinion, this is not the desired behavior.