Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs Request]: python_version when unspecified #303

Closed
jamesbraza opened this issue Nov 10, 2023 · 2 comments · Fixed by #308
Closed

[Docs Request]: python_version when unspecified #303

jamesbraza opened this issue Nov 10, 2023 · 2 comments · Fixed by #308
Labels
enhancement New feature or request

Comments

@jamesbraza
Copy link

Overview

python_version shows up in the docs in a few places:

It would be good to document what version it will use, when unspecified.

Proposal

It would be nice if the defaults for python_version would fall back on:

@jamesbraza jamesbraza added the enhancement New feature or request label Nov 10, 2023
@dosisod
Copy link
Owner

dosisod commented Nov 10, 2023

Thank you for opening this! When unspecified, Refurb uses the current interpreter version. Refurb does not look at the .python-version or pyproject.toml files for versions, though having an option to do this could be useful.

I'll update the docs to reflect the current behavior, and look into adding a flag to default to the min version in pyproject.toml/.python-version in the future.

@dosisod
Copy link
Owner

dosisod commented Nov 15, 2023

Thank you @jamesbraza for opening this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants