-
-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Warn datetime.{utcnow,utcfromtimestamp}
usages
#259
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for opening this PR! I'm a bit busy atm so I'm leaving a partial review, though I'll make sure to give this a full review by this time tomorrow.
Also, to answer your open questions:
Personally I prefer to pin my dev dependencies, but make sure they are regularly updated. I could probably do the same thing in Poetry, though I don't know how to do dev dependency pinning in Poetry (I'll look it up later). I'm open to solutions for handling dependencies better, so if you have any ideas on that I'd like to hear it! |
So devs will have their code updated automatically without the need to run `make install` each time. See dosisod#259 (comment)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall this looks really good! I left a few of minor notes, but once those are addressed I'll go ahead and merge this in!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! Sorry about CI failing, isort
should be disabled for the test data folder. I'll fix that tomorrow.
So devs will have their code updated automatically without the need to run `make install` each time. See #259 (comment)
Closes #258
Things I did:
tmp.py
to.gitignore
, because it is advertised to be used inadding-new-checks
Open questions:
pip install .
and notpip install -e .
Is it intentional?dev-requirements.txt
withpoetry
?We can discuss these questions in separate issues if you wish :)
Anyways, thanks a lot for the great package!