Fix: false negative in FURB111 #313
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosisod
approved these changes
Dec 22, 2023
There was a problem hiding this comment.
Thank you for catching this! Sorry this PR slipped under the radar, merging now.
I also went ahead and updated the err_111.txt file. Whenever you add/remove/modify the err_xyz.py files you need to run make update-tests to regenerate the data files. It's documented in the "Adding New Checks" file, though there isn't a link to it anywhere, so I'll add a link to the README.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found that
lambda x, t: tf.cast(x, t)was not found by theuse-func-namerule.This should solve it.
(Was looking for a similar rule to implement #290)