Add no-subclass-builtin check
#324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes #323. I am disabling this check by default for 2 reasons: * `isinstance(x, dict)` fails for `UserDict` objects (including `list`/`str`) * Changing `dict` to `UserDict` is not a quick fix, and you will probably have to change your class definition to get the most out of `UserDict` (ie, removing reimplemented methods, something Refurb can't easily detect). Teams that want to enforce this can enable this option, but overall, it is hard to deduce what is/is not proper usage of classes subclassing `dict`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #323.
I am disabling this check by default for 2 reasons:
isinstance(x, dict)fails forUserDictobjects (includinglist/str)dicttoUserDictis not a quick fix, and you will probably have to change your class definition to get the most out ofUserDict(ie, removing reimplemented methods, something Refurb can't easily detect).Teams that want to enforce this can enable this option, but overall, it is hard to deduce what is/is not proper usage of classes subclassing
dict.