Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logging in without role/tabs results in hung login screen. #16598

Closed
mattyarbrough opened this issue May 20, 2019 · 1 comment
Closed

Logging in without role/tabs results in hung login screen. #16598

mattyarbrough opened this issue May 20, 2019 · 1 comment

Comments

@mattyarbrough
Copy link

Describe the bug

A user who attempts to log in but does not have roles assigned or has a roles with no tabs assigned will see only the hung login screen.

Steps to reproduce the behavior:

  1. Create user with no role
  2. log in

Note that on the backend we do correctly classify this as a 403 error but that is not sent to the browser.

WARN auth.PrincipalThreadLocal - getName null
12:39:42.763 INFO util.SecurityLogger - class com.dotcms.cms.login.LoginServiceAPIFactory$LoginServiceImpl : User dotcms.org.2908 has successfully login from IP:-2450-12:39:42.788 INFO util.SecurityLogger - class com.dotmarketing.cms.login.factories.LoginFactory : User test@test.com has sucessfully login from IP:-2451-12:39:42.790 ERROR business.HostAPIImpl - User dotcms.org.2908 does not have permission to host:demo.dotcms.com
12:39:42.799 WARN exception.ForbiddenException - {“error”:“dotcms.api.error.forbidden: User dotcms.org.2908 does not have permission to host:demo.dotcms.com”}
com.dotcms.rest.exception.ForbiddenException: HTTP 403 Forbidden

Expected behavior

A clear message/403 should be returned to user

Desktop (please complete the following information):

  • OS: [e.g. iOS]
  • Browser [e.g. chrome, safari]
  • Version 4.x, 5.x

Additional context

Add any other context about the problem here.

Acceptance Criteria

  1. Match the design
  2. Work in all the supported browsers (don't forget IE11 and iPad)
  3. Multilanguage
  4. Unit test
@stale
Copy link

stale bot commented Sep 27, 2019

This issue has been automatically marked as stale because it has not had activity within the past 90 days. It will be closed in 30 days no further activity occurs. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant