Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let's add the Device Content Type to the starter! #24250

Closed
Tracked by #24862
jdcmsd opened this issue Mar 1, 2023 · 4 comments · Fixed by #25466
Closed
Tracked by #24862

Let's add the Device Content Type to the starter! #24250

jdcmsd opened this issue Mar 1, 2023 · 4 comments · Fixed by #25466

Comments

@jdcmsd
Copy link
Contributor

jdcmsd commented Mar 1, 2023

Parent Issue

#24862

Problem Statement

The Device (previewDevice) feature, selectable in Edit/Preview/Live Mode, has been an undocumented feature for some time, and a frequent headache for Support. As of today, it's documented. However, it seems like a random bit of busywork to give to users — build this Content Type with these specific variables that dotCMS is already hard coded to look for.

Could we just include this as one of the Content Types that ships in our blank starters, etc., even if we don't instantiate any default Device contentlets?

Steps to Reproduce

This is more of a QoL deficiency than a per se bug: Spin up a blank dotCMS instance, and you'll need to create this Content Type with 8 fields by hand. I did it a few times while testing it; it's not a huge drag, but it does feel gratuitous.

Acceptance Criteria

New, blank dotCMS instances have the Device content type ready to go from the jump.

dotCMS Version

All versions that I can see, going back years.

Proposed Objective

User Experience

Proposed Priority

Priority 4 - Trivial

External Links... Slack Conversations, Support Tickets, Figma Designs, etc.

No response

Assumptions & Initiation Needs

No response

Quality Assurance Notes & Workarounds

No response

Sub-Tasks & Estimates

No response

@github-actions
Copy link

github-actions bot commented Jun 9, 2023

This issue is stale because it has been open 90 days with no activity. Remove stale label or comment or this will be closed in 30 days.

@nollymar
Copy link
Contributor

A new empty starter has been generated to include the Device content type. Starter version: empty_20230710

@nollymar nollymar removed their assignment Jul 10, 2023
@nollymar nollymar linked a pull request Jul 10, 2023 that will close this issue
@nollymar nollymar reopened this Jul 11, 2023
@dcolina dcolina self-assigned this Jul 12, 2023
@dcolina dcolina added the Merged label Jul 12, 2023
@dcolina
Copy link
Contributor

dcolina commented Jul 12, 2023

Internal QA PASSED.

Correctly added the Device (PreviewDevice) content type as part of the empty starter.

Step by step:

  1. Load the web application and click on the content types menu.

Image

  1. Click on Device content type

Image

@josemejias11
Copy link

Approved QA - Tested on master_183eee1_SNAPSHOT // Docker // macOS 13.0 // FF v113.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

5 participants