Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Block Editor: Action button misplaced on images and video load #24594

Closed
zJaaal opened this issue Apr 11, 2023 · 2 comments · Fixed by #24598 or #24621
Closed

Block Editor: Action button misplaced on images and video load #24594

zJaaal opened this issue Apr 11, 2023 · 2 comments · Fixed by #24598 or #24621
Assignees
@fmontes @manuelrojas
Labels
QA : Approved Release : 23.05 Team : Lunik Type : Defect

Comments

@zJaaal
Copy link
Contributor

zJaaal commented Apr 11, 2023

Parent Issue

No response

Problem Statement

When you add an image or a video, the action button is miscalculating it's position

Steps to Reproduce

Grabacion.de.pantalla.2023-04-11.a.la.s.09.34.04.mov

Acceptance Criteria

  • Action button should be place in the next empty block, instead of in the middle of the image/video

dotCMS Version

master

Proposed Objective

Core Features

Proposed Priority

Priority 2 - Important

External Links... Slack Conversations, Support Tickets, Figma Designs, etc.

No response

Assumptions & Initiation Needs

No response

Quality Assurance Notes & Workarounds

No response

Sub-Tasks & Estimates

No response
@zJaaal zJaaal mentioned this issue Apr 11, 2023
Closed
2 tasks
@zJaaal zJaaal linked a pull request Apr 11, 2023 that will close this issue
Fix #24594: Block Editor Action Button Misplaced On Images And Video Load #24598
Merged
3 tasks
@zJaaal zJaaal self-assigned this Apr 11, 2023
@manuelrojas
Copy link
Contributor

Adding this PR to fix the issue with bigger videos

@zJaaal zJaaal linked a pull request Apr 12, 2023 that will close this issue
Fix image and video size #24621
Merged
3 tasks
@fmontes fmontes assigned fmontes and manuelrojas and unassigned zJaaal Apr 17, 2023
@fmontes fmontes mentioned this issue Apr 18, 2023
Closed
@bryanboza
Copy link
Member

Fixed, Now I'm unable to reproduce on release-23.05 // Docker // FF

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fmontes fmontes

@manuelrojas manuelrojas

Labels
QA : Approved Release : 23.05 Team : Lunik Type : Defect
Projects
dotCMS - Product Planning
Archived in project
Milestone
No milestone
6 participants
@fmontes @bryanboza @manuelrojas @zJaaal @damen-dotcms @josemejias11