Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove remote call from js #25972

Closed
wezell opened this issue Aug 31, 2023 · 3 comments · Fixed by #25973
Closed

remove remote call from js #25972

wezell opened this issue Aug 31, 2023 · 3 comments · Fixed by #25973
Assignees
@oidacra
Labels
Merged QA : Approved QA : Passed Internal Release : 23.10.24 Bug-Fixing Team : Falcon Type : Defect

Comments

@wezell
Copy link
Contributor

wezell commented Aug 31, 2023 •
edited

Parent Issue

No response

Problem Statement

The lib.js we ship with includes a call to jitsu.com - we need to remove this and have it call the local environment.

Steps to Reproduce

look at your network tab

Acceptance Criteria

not make call to jitsu.com

dotCMS Version

23.08

Proposed Objective

Security & Privacy

Proposed Priority

Priority 2 - Important
@wezell
Copy link
Contributor Author

wezell commented Aug 31, 2023

See:
https://github.com/dotCMS/jitsu/commit/af591d413c2056ef3dbc0ef6192375df8fe762f4

@wezell wezell linked a pull request Aug 31, 2023 that will close this issue
bug: remove jitsu.com fallback if tracking_host not set #25973
Merged
@dsilvam dsilvam reopened this Sep 3, 2023
@oidacra oidacra self-assigned this Sep 11, 2023
@oidacra
Copy link
Member

oidacra commented Sep 11, 2023

IQA Passed:
lib.js now comes from the local environment

Image

@oidacra oidacra closed this as completed Sep 11, 2023
@bryanboza
Copy link
Member

Fixed, tested on master // Docker // FF

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oidacra oidacra

Labels
Merged QA : Approved QA : Passed Internal Release : 23.10.24 Bug-Fixing Team : Falcon Type : Defect
Projects
dotCMS - Product Planning
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

bug: remove jitsu.com fallback if tracking_host not set dotCMS/core
5 participants
@wezell @dsilvam @oidacra @bryanboza @damen-dotcms