Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edit Contentlet: Allow user to upload files from external sources #26047

Closed
Tracked by #25445
rjvelazco opened this issue Sep 11, 2023 · 5 comments · Fixed by #26313
Closed
Tracked by #25445

Edit Contentlet: Allow user to upload files from external sources #26047

rjvelazco opened this issue Sep 11, 2023 · 5 comments · Fixed by #26313

Comments

@rjvelazco
Copy link
Contributor

rjvelazco commented Sep 11, 2023

Parent Issue

#25445

Task

As a dotCMS user, I want to be able to upload files from external sources by copying/pasting the URL.

Proposed Objective

Core Features

Proposed Priority

Priority 3 - Average

Acceptance Criteria

  • Allow the user to upload files from external sources
  • Handle Invalid URL errors.
  • Handle server errors that may occur during the upload or publication of the workflow action.

External Links... Slack Conversations, Support Tickets, Figma Designs, etc.

allow the user to upload files from external sources

Assumptions & Initiation Needs

No response

Quality Assurance Notes & Workarounds

No response

Sub-Tasks & Estimates

No response

@fmontes fmontes changed the title Content Edit Refactor: Allow user to upload files from external sources Edit Contentlet: Allow user to upload files from external sources Sep 18, 2023
@rjvelazco rjvelazco self-assigned this Sep 27, 2023
@KevinDavilaDotCMS
Copy link
Contributor

Pass internal QA

Tested on master

Screen.Recording.2023-10-09.at.12.45.20.mov

@josemejias11 josemejias11 reopened this Oct 10, 2023
@josemejias11
Copy link

josemejias11 commented Oct 10, 2023

Failed: Tested on master_efcccfc_SNAPSHOT, Docker, macOS 13.0, FF v113.0

Screen.Recording.2023-10-10.at.11.47.40.AM.mov

Seems that we are able to import anything and everything we try to upload to the binary field. Should we have a checklist of posible allow files to handle?

@fmontes
Copy link
Member

fmontes commented Oct 12, 2023

Binary will take everything... you can limit what it takes using field variables https://www.dotcms.com/docs/latest/binary-field#FieldVariables

@rjvelazco
Copy link
Contributor Author

rjvelazco commented Oct 13, 2023

@josemejias11 We do have a field variable called accept that you can configure in the binary field for that. The problem is that the backend does not validate that yet and is not returning the extension/mimeType to validate in the Front-end when you upload a file using the temp API by URL endpoint. We have a ticket for that: #26340

@josemejias11
Copy link

Approved: Tested on master_534774e_SNAPSHOT, Docker, macOS 13.0, FF v113.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

7 participants