Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugins deployer needs to track & remove ROOT added files #9805

Closed
chrismccracken opened this issue Sep 19, 2016 · 1 comment
Closed

Plugins deployer needs to track & remove ROOT added files #9805

chrismccracken opened this issue Sep 19, 2016 · 1 comment

Comments

@chrismccracken
Copy link
Contributor

Expected Behavior

Plugins deployer will keep tracking information for any files added from plugins/$plugin/ROOT/.
Plugins deployer will UNDEPLOY these added files when plugin is undeployed.

Current Behavior

Plugins deployer adds files from plugins/$plugin/ROOT/.
Plugins deployer does not track these files.
Plugins UNDEPLOY does not remove these added files and they persist forever.

Possible Solution

Store a per-plugin ROOT-ADDED-MANIFEST.txt file in _original to allow undeploy of added files. Overridden files are currently tracked, we only need to handle added files.

Known Workarounds

Manually track all added files and manually remove them on undeploy.

Steps to Reproduce (for bugs)

  1. Create files under plugins/$plugin/ROOT/ that do not currently exist
  2. Deploy plugins, verify files added
  3. Undeploy plugins, check if they have been removed
    4.

Context

Your Environment

  • dotCMS version used: 3.5.1
  • Browser Name and version:
  • Operating System and version: Linux
  • Application Server and version: Embedded
  • Java Brand and version: 1.8
  • Database and version:
  • Application module (if apply):
@jgambarios jgambarios added this to the 3.7.0 milestone Sep 19, 2016
@jgambarios jgambarios removed this from the 3.7.0 milestone Oct 31, 2016
@stale
Copy link

stale bot commented Sep 28, 2019

This issue has been automatically marked as stale because it has not had activity within the past 90 days. It will be closed in 30 days no further activity occurs. Thank you.

@stale stale bot added the wontfix label Sep 28, 2019
@stale stale bot closed this as completed Oct 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants