CompositeStateTrigger cannot have AdaptiveTrigger in collection

[sibbl]

Unfortunately the following code does not work, but I'd love to have setters for e.g. "desktop device family and window width greater than 500px":

<VisualState.StateTriggers>
    <windowsStateTriggers:CompositeStateTrigger Operator="And">
        <windowsStateTriggers:DeviceFamilyStateTrigger DeviceFamily="Desktop" />
        <AdaptiveTrigger MinWindowWidth="500" />
    </windowsStateTriggers:CompositeStateTrigger>
</VisualState.StateTriggers>

Is there anything that can be done?

[Rexobias]

I have the same question.

[tibitoth]

We can't use the AdaptiveTrigger in CompositeStateTrigger, because it isn't implement the ITriggerValue interface. I think we need to reimplement this trigger.

[tibitoth]

I created a pull request #48 with ITriggerValue implementation.

[dotMorten]

@totht91 Thanks nice job, but is there a reason we wouldn't just still call it "AdaptiveTrigger" ?

[tibitoth]

We can call it 👍

[Rexobias]

Thank you ;)

[tibitoth]

NP. But it's not merged yet.

[sibbl]

@dotMorten may I ask why this is still not merged? It would be good for this project to have the AdaptiveTrigger merged, wouldn't it?

[tibitoth]

It's feel like an abandoned repo.

[dotMorten]

@sibbl or like WPF it's 'mature' :) The question I asked last wasn't answered.

[tibitoth]

So WindowsStateTriggers is mature?

[sibbl]

If I'm correct, you, @dotMorten, want @totht91 to rename the CompositableAdaptiveTrigger to AdaptiveTrigger, right? Or are you waiting for more changes to merge the new PR and release the new version on Nuget?

[tibitoth]

I renamed it. https://github.com/totht91/WindowsStateTriggers/commit/139ea9fde0e037c5c5206d775aca42eb7764a6db

[sibbl]

Oh, indeed - sorry, @totht91. Okay, what answer for which question are you then waiting for, @dotMorten? ;)

[ndeeH]

Please update the nuget version. Thank you.

[dotMorten]

merged and nuget updated

[genfa]

Hello, I'm currently trying to use the trigger in a UWP with several resolutions
<WindowsStateTriggers:CompositeStateTrigger Operator="And" > <WindowsStateTriggers:AdaptiveTrigger MinWindowWidth="100"/> <WindowsStateTriggers:DeviceFamilyStateTrigger DeviceFamily="Desktop"/> </WindowsStateTriggers:CompositeStateTrigger>
with the latest nugget package (02/02) but only the first visualstate is executed. Do you have a example to use the composite trigger?

[tibitoth]

What do you mean "only the first visualstate is executed"? Your sample (min window width and device family) is worked for me flawlessly.

[genfa]

If a second visual state is defined with a different resolution
<WindowsStateTriggers:CompositeStateTrigger Operator="And" > <WindowsStateTriggers:AdaptiveTrigger MinWindowWidth="500"/> <WindowsStateTriggers:DeviceFamilyStateTrigger DeviceFamily="Desktop"/> </WindowsStateTriggers:CompositeStateTrigger>
and I resize my app while running, to more then 500, the visual state is not applied. If I use only the builtin <AdaptativeTrigger>, everything run fine.
For my app, I use a VisualState for Phone (with the DeviceFamilyStateTrigger), and the other ones for the desktop without the DeviceFamilyStateTrigger and with the builtin AdaptativeTrigger.

[dotMorten]

Could you please open an issue and post a full sample that demonstrates the problem?
I'm terrible at guessing reproducers ;-)

[genfa]

I'll do it this evening.
A reproductible bug is half resolved :)