Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix ESM graphql import #469

Merged
merged 1 commit into from
Jul 23, 2021
Merged

fix ESM graphql import #469

merged 1 commit into from
Jul 23, 2021

Conversation

PabloSzx
Copy link
Collaborator

ESM compatibility was broken with the import of 'graphql/jsutils/isAsyncIterable', since the extension was not specified.

This issue can be reproduced simply going to the with-esm example and run "yarn start"

Screenshot at Jul 22 20-11-50

@changeset-bot
Copy link

changeset-bot bot commented Jul 23, 2021

🦋 Changeset detected

Latest commit: 47cb0d7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 11 packages
Name Type
@envelop/core Patch
@envelop/apollo-server-errors Patch
@envelop/apollo-tracing Patch
@envelop/execute-subscription-event Patch
@envelop/newrelic Patch
@envelop/opentelemetry Patch
@envelop/preload-assets Patch
@envelop/prometheus Patch
@envelop/sentry Patch
@envelop/testing Patch
@envelop/operation-field-permissions Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Jul 23, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/theguild/envelop/GvzKsSonkj7HqFu2nMRt2AKihsy5
✅ Preview: https://envelop-git-fix-esm-theguild.vercel.app

@theguild-bot
Copy link
Collaborator

The latest changes of this PR are available as alpha in npm (based on the declared changesets):

@envelop/core@1.0.1-alpha-43507d7.0
@envelop/apollo-server-errors@1.0.1-alpha-43507d7.0
@envelop/apollo-tracing@1.0.1-alpha-43507d7.0
@envelop/execute-subscription-event@0.0.2-alpha-43507d7.0
@envelop/newrelic@1.0.1-alpha-43507d7.0
@envelop/opentelemetry@1.0.1-alpha-43507d7.0
@envelop/operation-field-permissions@1.0.1-alpha-43507d7.0
@envelop/preload-assets@1.0.1-alpha-43507d7.0
@envelop/prometheus@1.0.1-alpha-43507d7.0
@envelop/sentry@1.0.1-alpha-43507d7.0
@envelop/testing@1.0.1-alpha-43507d7.0

@theguild-bot
Copy link
Collaborator

✅ Benchmark Results

     ✓ no_errors
     ✓ expected_result

     checks.............................................: 100.00% ✓ 151258      ✗ 0    
     data_received......................................: 583 MB  12 MB/s
     data_sent..........................................: 33 MB   660 kB/s
     envelop_init.......................................: avg=1.22µs   min=300ns    med=700ns   max=1.3ms   p(90)=2.2µs   p(95)=2.6µs   
     ✓ { mode:envelop-cache-jit }.......................: avg=740ns    min=300ns    med=600ns   max=582µs   p(90)=1.1µs   p(95)=1.2µs   
     ✓ { mode:envelop-just-cache }......................: avg=693ns    min=400ns    med=700ns   max=33.8µs  p(90)=900ns   p(95)=1µs     
     ✓ { mode:graphql-js }..............................: avg=1.76µs   min=400ns    med=1.1µs   max=1.3ms   p(90)=2.7µs   p(95)=3µs     
     ✓ { mode:prom-tracing }............................: avg=4.14µs   min=1.3µs    med=2.1µs   max=1.12ms  p(90)=8.2µs   p(95)=8.5µs   
     envelop_total......................................: avg=310.77µs min=0s       med=126.1µs max=13.7ms  p(90)=498.6µs p(95)=1.48ms  
     ✓ { mode:envelop-cache-jit }.......................: avg=125.84µs min=106.9µs  med=118µs   max=10.54ms p(90)=134µs   p(95)=144.9µs 
     ✓ { mode:envelop-just-cache }......................: avg=370.04µs min=304.7µs  med=323.6µs max=12.66ms p(90)=353.8µs p(95)=405.47µs
     ✓ { mode:graphql-js }..............................: avg=532.81µs min=404.8µs  med=446.5µs max=13.7ms  p(90)=523.6µs p(95)=1ms     
     ✓ { mode:prom-tracing }............................: avg=1.64ms   min=1.42ms   med=1.5ms   max=10.73ms p(90)=1.81ms  p(95)=2.67ms  
     graphql_context....................................: avg=2.71µs   min=1.1µs    med=2µs     max=6.45ms  p(90)=5.2µs   p(95)=5.8µs   
     ✓ { mode:envelop-cache-jit }.......................: avg=1.64µs   min=1.1µs    med=1.5µs   max=49.9µs  p(90)=2.1µs   p(95)=2.2µs   
     ✓ { mode:envelop-just-cache }......................: avg=2.23µs   min=1.4µs    med=2.1µs   max=1.06ms  p(90)=2.4µs   p(95)=2.6µs   
     ✓ { mode:graphql-js }..............................: avg=4.07µs   min=1.9µs    med=2.9µs   max=6.45ms  p(90)=4.5µs   p(95)=7.1µs   
     ✓ { mode:prom-tracing }............................: avg=6.8µs    min=4.8µs    med=5.7µs   max=1ms     p(90)=8.2µs   p(95)=8.6µs   
     graphql_execute....................................: avg=340.75µs min=74.7µs   med=282.4µs max=13.55ms p(90)=1.09ms  p(95)=1.41ms  
     ✓ { mode:envelop-cache-jit }.......................: avg=89.06µs  min=74.7µs   med=83.3µs  max=8.2ms   p(90)=93.5µs  p(95)=101.9µs 
     ✓ { mode:envelop-just-cache }......................: avg=330.66µs min=271.2µs  med=287.2µs max=12.39ms p(90)=310.6µs p(95)=350.25µs
     ✓ { mode:graphql-js }..............................: avg=357.16µs min=274.5µs  med=294.3µs max=13.55ms p(90)=328.9µs p(95)=391.15µs
     ✓ { mode:prom-tracing }............................: avg=1.55ms   min=1.35ms   med=1.41ms  max=10.64ms p(90)=1.59ms  p(95)=2.59ms  
     graphql_parse......................................: avg=10.24µs  min=2.8µs    med=4.4µs   max=7.87ms  p(90)=27.15µs p(95)=34.2µs  
     ✓ { mode:envelop-cache-jit }.......................: avg=4.82µs   min=3.2µs    med=4.3µs   max=1.37ms  p(90)=6.3µs   p(95)=6.8µs   
     ✓ { mode:envelop-just-cache }......................: avg=4.58µs   min=2.8µs    med=3.7µs   max=1.43ms  p(90)=9.4µs   p(95)=11.2µs  
     ✓ { mode:graphql-js }..............................: avg=17.36µs  min=7.7µs    med=13.6µs  max=7.87ms  p(90)=20.1µs  p(95)=24.1µs  
     ✓ { mode:prom-tracing }............................: avg=40.45µs  min=28.7µs   med=34.1µs  max=7.84ms  p(90)=45.3µs  p(95)=52.67µs 
     graphql_validate...................................: avg=52.21µs  min=24.6µs   med=29.2µs  max=12.3ms  p(90)=131.1µs p(95)=136.4µs 
     ✓ { mode:envelop-cache-jit }.......................: avg=29.57µs  min=24.6µs   med=27.9µs  max=2.04ms  p(90)=33.4µs  p(95)=35.1µs  
     ✓ { mode:envelop-just-cache }......................: avg=31.87µs  min=24.7µs   med=28.6µs  max=12.3ms  p(90)=34.1µs  p(95)=38.9µs  
     ✓ { mode:graphql-js }..............................: avg=152.45µs min=114.2µs  med=132.1µs max=9.39ms  p(90)=163.8µs p(95)=179.9µs 
     ✓ { mode:prom-tracing }............................: avg=37.72µs  min=31.1µs   med=35.8µs  max=1.18ms  p(90)=40.3µs  p(95)=42µs    
     http_req_blocked...................................: avg=3.41µs   min=600ns    med=1.5µs   max=7.86ms  p(90)=2.2µs   p(95)=3µs     
     http_req_connecting................................: avg=1.09µs   min=0s       med=0s      max=4.13ms  p(90)=0s      p(95)=0s      
     http_req_duration..................................: avg=6.17ms   min=303µs    med=4.34ms  max=81.05ms p(90)=14.24ms p(95)=16.09ms 
       { expected_response:true }.......................: avg=6.17ms   min=303µs    med=4.34ms  max=81.05ms p(90)=14.24ms p(95)=16.09ms 
     ✓ { mode:envelop-cache-and-no-internal-tracing }...: avg=5.22ms   min=511.9µs  med=4.11ms  max=67.44ms p(90)=8.69ms  p(95)=9.99ms  
     ✓ { mode:envelop-cache-jit }.......................: avg=3.34ms   min=303µs    med=2.3ms   max=30.72ms p(90)=7.84ms  p(95)=10.93ms 
     ✓ { mode:envelop-just-cache }......................: avg=5.65ms   min=511.7µs  med=4.54ms  max=53.49ms p(90)=9.33ms  p(95)=11.81ms 
     ✓ { mode:graphql-js }..............................: avg=9.6ms    min=798.41µs med=9.7ms   max=64.88ms p(90)=14.73ms p(95)=17.4ms  
     ✓ { mode:prom-tracing }............................: avg=18.15ms  min=2.95ms   med=15.98ms max=81.05ms p(90)=31.09ms p(95)=32.44ms 
     http_req_failed....................................: 0.00%   ✓ 0           ✗ 75629
     http_req_receiving.................................: avg=54.25µs  min=13.2µs   med=25µs    max=24.03ms p(90)=36.5µs  p(95)=41.3µs  
     http_req_sending...................................: avg=57.41µs  min=5.2µs    med=9.4µs   max=21.61ms p(90)=17.8µs  p(95)=25.1µs  
     http_req_tls_handshaking...........................: avg=0s       min=0s       med=0s      max=0s      p(90)=0s      p(95)=0s      
     http_req_waiting...................................: avg=6.05ms   min=261.1µs  med=4.25ms  max=80.97ms p(90)=13.88ms p(95)=16ms    
     http_reqs..........................................: 75629   1511.871788/s
     iteration_duration.................................: avg=6.61ms   min=552.8µs  med=4.71ms  max=81.37ms p(90)=14.87ms p(95)=16.49ms 
     iterations.........................................: 75629   1511.871788/s
     vus................................................: 0       min=0         max=19 
     vus_max............................................: 40      min=40        max=40 

@dotansimha dotansimha merged commit 8021229 into main Jul 23, 2021
@n1ru4l n1ru4l deleted the fix-esm branch July 23, 2021 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants