New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(solid-query): add plugin #474
Conversation
🦋 Changeset detectedLatest commit: 515d05c The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Hey! Sorry for the delay. Assigning myself for review so I can get it done this week |
@saihaj any update ? |
1 similar comment
@saihaj any update ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we would also need to update codegen website in the codegen repo to this package
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
actually before we merge. make that version change in package json I proposed and then run yarn changeset
and create a major
then it will automatically work with your deploy setup
Co-authored-by: Saihajpreet Singh <saihajpreet.singh@gmail.com>
Co-authored-by: Saihajpreet Singh <saihajpreet.singh@gmail.com>
|
@saihaj ready to merge ! |
@saihaj any update ? |
@saihaj changes done |
@saihaj any update ? |
3 similar comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sorry for the delay
🚨 IMPORTANT: Please do not create a Pull Request without creating an issue first.
#469
Description
Implement Solid-query generator
Related #469
Type of change
Please delete options that are not relevant.
expected)
How Has This Been Tested?
Use existing tests for react-query and change it accordingly to solid query documentation https://tanstack.com/query/latest/docs/solid/overview
Checklist:
CONTRIBUTING doc and the
style guidelines of this project