Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(solid-query): add plugin #474

Merged
merged 5 commits into from Feb 1, 2024
Merged

feat(solid-query): add plugin #474

merged 5 commits into from Feb 1, 2024

Conversation

qlaffont
Copy link
Contributor

🚨 IMPORTANT: Please do not create a Pull Request without creating an issue first.

#469

Description

Implement Solid-query generator

Related #469

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as
    expected)
  • This change requires a documentation update

How Has This Been Tested?

Use existing tests for react-query and change it accordingly to solid query documentation https://tanstack.com/query/latest/docs/solid/overview

Checklist:

  • I have followed the
    CONTRIBUTING doc and the
    style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@changeset-bot
Copy link

changeset-bot bot commented Oct 26, 2023

🦋 Changeset detected

Latest commit: 515d05c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@graphql-codegen/typescript-solid-query Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@qlaffont
Copy link
Contributor Author

@saihaj / @TkDodo can you review my PR please ? :)

@qlaffont
Copy link
Contributor Author

@dotansimha 👋

@saihaj saihaj self-requested a review November 9, 2023 00:17
@saihaj
Copy link
Collaborator

saihaj commented Nov 9, 2023

Hey! Sorry for the delay. Assigning myself for review so I can get it done this week

@qlaffont
Copy link
Contributor Author

@saihaj any update ?

1 similar comment
@qlaffont
Copy link
Contributor Author

@saihaj any update ?

@qlaffont
Copy link
Contributor Author

@dotansimha ?

Copy link
Collaborator

@saihaj saihaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we would also need to update codegen website in the codegen repo to this package

Copy link
Collaborator

@saihaj saihaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actually before we merge. make that version change in package json I proposed and then run yarn changeset and create a major then it will automatically work with your deploy setup

qlaffont and others added 2 commits December 24, 2023 10:47
Co-authored-by: Saihajpreet Singh <saihajpreet.singh@gmail.com>
Co-authored-by: Saihajpreet Singh <saihajpreet.singh@gmail.com>
@qlaffont
Copy link
Contributor Author

@saihaj

@qlaffont ➜ /workspaces/graphql-code-generator-community (main) $ yarn changeset major
yarn run v1.22.19
error Command "changeset" not found.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
@qlaffont ➜ /workspaces/graphql-code-generator-community (main) $ yarn
yarn install v1.22.19
[1/4] Resolving packages...
[2/4] Fetching packages...
error https://registry.yarnpkg.com/typescript/-/typescript-4.9.5.tgz: Extracting tar content of undefined failed, the file appears to be corrupt: "ENOENT: no such file or directory, stat '/home/codespace/.cache/yarn/v6/npm-typescript-4.9.5-095979f9bcc0d09da324d58d03ce8f8374cbe65a-integrity/node_modules/typescript/lib/typescript.js'"
info Visit https://yarnpkg.com/en/docs/cli/install for documentation about this command.

@qlaffont
Copy link
Contributor Author

@saihaj ready to merge !

@qlaffont
Copy link
Contributor Author

qlaffont commented Jan 5, 2024

@saihaj any update ?

@qlaffont
Copy link
Contributor Author

@saihaj changes done

@qlaffont
Copy link
Contributor Author

@saihaj any update ?

2 similar comments
@qlaffont
Copy link
Contributor Author

@saihaj any update ?

@qlaffont
Copy link
Contributor Author

@saihaj any update ?

@qlaffont
Copy link
Contributor Author

@dotansimha @saihaj 👋

3 similar comments
@qlaffont
Copy link
Contributor Author

@dotansimha @saihaj 👋

@qlaffont
Copy link
Contributor Author

@dotansimha @saihaj 👋

@qlaffont
Copy link
Contributor Author

@dotansimha @saihaj 👋

Copy link
Collaborator

@saihaj saihaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry for the delay

@saihaj saihaj merged commit bb1f064 into dotansimha:main Feb 1, 2024
14 checks passed
@github-actions github-actions bot mentioned this pull request Feb 1, 2024
@saihaj
Copy link
Collaborator

saihaj commented Feb 2, 2024

@qlaffont it is available on NPM https://github.com/dotansimha/graphql-code-generator-community/releases/tag/release-1706889435949

@qlaffont qlaffont mentioned this pull request Feb 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants