Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(typescript-react-apollo): Add options support to useFragment #742

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

rohit-gohri
Copy link
Contributor

@rohit-gohri rohit-gohri commented Jun 9, 2024

Description

Updates useFragment generate hooks to include options and fix name of fragment doc to handle PascalCase conversion.

Related #711

Type of change

  • New feature (non-breaking change which adds functionality)

Screenshots/Sandbox (if appropriate/relevant):

Adding links to sandbox or providing screenshots can help us understand more about this PR and take
action on it as appropriate

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can
reproduce. Please also list any relevant details for your test configuration

  • tested locally in my own project
  • updated existing useFragment test, updated a dev-test file, ran yarn build, yarn generate:examples, yarn test and all completed successfully

Test Environment:

  • OS: Mac
  • @graphql-codegen/cli: "^5.0.2",
  • @graphql-codegen/typescript-react-apollo: 4.3.0
  • NodeJS: v20.11.0

Checklist:

  • I have followed the
    CONTRIBUTING doc and the
    style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose
the solution you did and what alternatives you considered, etc...

Copy link

changeset-bot bot commented Jun 9, 2024

🦋 Changeset detected

Latest commit: dd93ece

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@graphql-codegen/typescript-react-apollo Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@rohit-gohri rohit-gohri changed the title add options support to useFragment Add options support to useFragment Jun 9, 2024
@rohit-gohri rohit-gohri changed the title Add options support to useFragment feat(typescript-react-apollo): Add options support to useFragment Jun 9, 2024
@rohit-gohri rohit-gohri marked this pull request as ready for review June 9, 2024 20:54
@rohit-gohri
Copy link
Contributor Author

Hey @saihaj , tagging you since you approved/published the original support for useFragment in #483 (comment)

Would be nice if you can check this out, or let me know if I can ask someone else for a review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant