fix: ignoreNoDocuments option usage when using graphql configs (#9371)

dotansimha · May 11, 2023 · d431f42 · d431f42
1 parent 0f85802
commit d431f42
Show file tree

Hide file tree

Showing 4 changed files with 50 additions and 4 deletions.
diff --git a/.changeset/quiet-rocks-sin.md b/.changeset/quiet-rocks-sin.md
@@ -0,0 +1,5 @@
+---
+'@graphql-codegen/cli': patch
+---
+
+Fixed option ignoreNoDocuments when using graphql configs
diff --git a/packages/graphql-codegen-cli/src/codegen.ts b/packages/graphql-codegen-cli/src/codegen.ts
@@ -274,10 +274,20 @@ export async function executeCodegen(input: CodegenContext | Types.Config): Prom
 
                           const hash = JSON.stringify(documentPointerMap);
                           const result = await cache('documents', hash, async () => {
-                            const documents = await context.loadDocuments(documentPointerMap);
-                            return {
-                              documents,
-                            };
+                            try {
+                              const documents = await context.loadDocuments(documentPointerMap);
+                              return {
+                                documents,
+                              };
+                            } catch (error) {
+                              if (config.ignoreNoDocuments) {
+                                return {
+                                  documents: [],
+                                };
+                              }
+
+                              throw error;
+                            }
                           });
 
                           outputDocuments = result.documents;

diff --git a/packages/graphql-codegen-cli/tests/generate-and-save.spec.ts b/packages/graphql-codegen-cli/tests/generate-and-save.spec.ts
@@ -3,6 +3,7 @@ import { Types } from '@graphql-codegen/plugin-helpers';
 import { useMonorepo } from '@graphql-codegen/testing';
 import makeDir from 'make-dir';
 import { generate } from '../src/generate-and-save.js';
+import { createContext } from '../src/config.js';
 import * as fs from '../src/utils/file-system.js';
 
 const SIMPLE_TEST_SCHEMA = `type MyType { f: String } type Query { f: String }`;
@@ -76,6 +77,22 @@ describe('generate-and-save', () => {
     expect(writeSpy).not.toHaveBeenCalled();
   });
 
+  test('should not error when ignoreNoDocuments config option is present', async () => {
+    jest.spyOn(fs, 'writeFile').mockImplementation();
+    const config = await createContext({
+      config: './tests/test-files/graphql.config.json',
+      project: undefined,
+      errorsOnly: true,
+      overwrite: true,
+      profile: true,
+      require: [],
+      silent: false,
+      watch: false,
+    });
+
+    await generate(config, false);
+  });
+
   test('should use global overwrite option and write a file', async () => {
     const filename = 'overwrite.ts';
     const writeSpy = jest.spyOn(fs, 'writeFile').mockImplementation();

diff --git a/packages/graphql-codegen-cli/tests/test-files/graphql.config.json b/packages/graphql-codegen-cli/tests/test-files/graphql.config.json
@@ -0,0 +1,14 @@
+{
+  "schema": ["../test-documents/schema.graphql"],
+  "documents": ["../test-documents/empty.graphql"],
+  "extensions": {
+    "codegen": {
+      "ignoreNoDocuments": true,
+      "generates": {
+        "./gql/": {
+          "preset": "client"
+        }
+      }
+    }
+  }
+}