Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding option for numeric typescript enums #4158

Merged
merged 3 commits into from Jun 4, 2020
Merged

Adding option for numeric typescript enums #4158

merged 3 commits into from Jun 4, 2020

Conversation

theomjones
Copy link
Contributor

@theomjones theomjones commented Jun 3, 2020

Covers #4157

  • Added option to types
  • Implement option functionality
  • Add tests

@dotansimha
Copy link
Owner

Thank you @theomjones !
Maybe the code there could be improved a bit? it seems a bit duplicated

@theomjones
Copy link
Contributor Author

@dotansimha - thanks, I've extracted some dupe code out into a function. Let me know if you need anything more

@dotansimha
Copy link
Owner

That's perfect, thank you @theomjones :)

@dotansimha dotansimha merged commit 6163b14 into dotansimha:master Jun 4, 2020
@theguild-bot
Copy link
Collaborator

The latest changes of this PR are available as alpha in npm: 1.15.2-alpha-6163b143.0

Quickly update your package.json by running:

npx match-version @graphql-codegen 1.15.2-alpha-6163b143.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants