Make types pascal cased #467
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arvind-chandrashekar-ck-zz
force-pushed
the
master
branch
from
421b72f
to
d0a28e7
Compare
|
@kamilkisiela can you please review? |
|
@dotansimha same as my change except there's no tests but we can merge one after another and have tests too |
|
@kamilkisiela I've updated the test spec with a test for the update I've made; let me know if any issues. Also thanks to you and @dotansimha for the timely feedback! |
|
@arvind-chandrashekar-ck thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The template doesn't currently Pascal case union types; this PR updates the schema handlebar to fix this.