Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This merge requests is an improvement over #4181 and fixes #4663. In GraphQL arrays, there are several nullable types:
[String]!
)[String!]
)[String]
)[String!]!]
)So far,
@graphql-codegen/typescript-type-graphql
did not support either of the cases where the items in the array can be null. This led to uncompilable code, which #4181 attempted to fix. However, there were two problems with this merge request:Maybe
only refers to a type, but is being used as a value here (only arrays) #4663TypeGraphQL supports nullable list types through the options
{ nullable: 'items' }
, and{ nullable: 'itemsAndList' }
, which this pull request will properly set on the field and input field decorators.