Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement additional configuration for C# plugin related to JSON attributes, remove redundant dependency on GraphQL namespace #6342

Merged
merged 2 commits into from
Aug 3, 2021

Conversation

seclerp
Copy link
Contributor

@seclerp seclerp commented Jul 18, 2021

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Related # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

The test was made using different sample schemas added to dev-test/codegen.yml with different arguments given to the plugin.

Test Environment:

  • OS: Windows
  • @graphql-codegen/cli (locally built)
  • @graphql-codegen/c-sharp (locally built)
  • NodeJS: 14.16.1

Checklist:

  • I have followed the CONTRIBUTING doc and the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Related #6340
Related #6341

…ibutes, remove redundant dependency on `GraphQL` namespace
@changeset-bot
Copy link

changeset-bot bot commented Jul 18, 2021

🦋 Changeset detected

Latest commit: 746eb9f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@graphql-codegen/c-sharp Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Owner

@dotansimha dotansimha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks nice, thank you @seclerp !
I see that the PR is still marked as draft, is there anything else missing before we can merge this?

@seclerp
Copy link
Contributor Author

seclerp commented Jul 22, 2021

@dotansimha thanks, I am stuck in manual testing this plugin as a local package, as it is a requirement for PR

@seclerp
Copy link
Contributor Author

seclerp commented Jul 22, 2021

I spent a lot of time trying to build plugin, it is not a changes related issue :)

@dotansimha
Copy link
Owner

dotansimha commented Jul 22, 2021

@dotansimha thanks, I am stuck in manual testing this plugin as a local package, as it is a requirement for PR

You can use yarn build to build all packages locally, and then you can use dev-test to create a local output. Take a look at dev-test/codegen.yml, we have a very long list of test outputs.

Also, if you want to test it locally in an external project, you can use npm pack in the project root, and then refer to the compressed tgz in a package.json.

@seclerp
Copy link
Contributor Author

seclerp commented Jul 22, 2021

@dotansimha thanks, I am stuck in manual testing this plugin as a local package, as it is a requirement for PR

You can use yarn build to build all packages locally, and then you can use dev-test to create a local output. Take a look at dev-test/codegen.yml, we have a very long list of test outputs.

Also, if you want to test it locally in an external project, you can use npm pack in the project root, and then refer to the compressed tgz in a package.json.

Thank you, will check it out and after testing will ping you

@seclerp seclerp marked this pull request as ready for review July 23, 2021 19:45
@seclerp
Copy link
Contributor Author

seclerp commented Jul 23, 2021

@dotansimha sorry for being late with that, I'm done with testing, PR could be merged

@seclerp
Copy link
Contributor Author

seclerp commented Jul 28, 2021

@dotansimha did you had a chance to look into it? 😃

@dotansimha
Copy link
Owner

Thanks @seclerp ! Sorry for the delay! :)

@dotansimha dotansimha merged commit b64475b into dotansimha:master Aug 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants