-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement additional configuration for C# plugin related to JSON attributes, remove redundant dependency on GraphQL
namespace
#6342
Conversation
…ibutes, remove redundant dependency on `GraphQL` namespace
🦋 Changeset detectedLatest commit: 746eb9f The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks nice, thank you @seclerp !
I see that the PR is still marked as draft, is there anything else missing before we can merge this?
@dotansimha thanks, I am stuck in manual testing this plugin as a local package, as it is a requirement for PR |
I spent a lot of time trying to build plugin, it is not a changes related issue :) |
You can use Also, if you want to test it locally in an external project, you can use |
Thank you, will check it out and after testing will ping you |
@dotansimha sorry for being late with that, I'm done with testing, PR could be merged |
@dotansimha did you had a chance to look into it? 😃 |
Thanks @seclerp ! Sorry for the delay! :) |
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Related # (issue)
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
The test was made using different sample schemas added to
dev-test/codegen.yml
with different arguments given to the plugin.Test Environment:
@graphql-codegen/cli
(locally built)@graphql-codegen/c-sharp
(locally built)Checklist:
Related #6340
Related #6341