-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add patch GraphQL 16 changeset for packages that were left out #7202
Conversation
🦋 Changeset detectedLatest commit: 9a5ee07 The changes in this PR will be included in the next version bump. This PR includes changesets to release 12 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/theguild/graphql-code-generator/EesuNctD6AubKaqLFZr53pKs6XYv |
5aecf05
to
9a5ee07
Compare
Actually I took a different approach for this. I created an empty project with dep
I changed I'm not 100% sure if everything is covered but I'm pretty sure that I didn't miss anything. And yes, manual work was included but maybe you can verify missing peerDeps by trying to install those packages. |
|
We didn't miss it, it's an external package that doesn't support graphql v16 yet. |
🚨 IMPORTANT: Please do not create a Pull Request without creating an issue first.
Any change needs to be discussed before proceeding. Failure to do so may result in the rejection of the pull request.
Description
Added
patch
changeset for GraphQL16 version bump for packages that were left out in 97ddb48#diff-0162fb12b66d02773262d9cb1ea902dbe2f6c3b429593b772c2fa5d3e8293cafRelated #7003 & #7109
Type of change
Please delete options that are not relevant.
Screenshots/Sandbox (if appropriate/relevant):
Adding links to sandbox or providing screenshots can help us understand more about this PR and take action on it as appropriate
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Test Environment:
@graphql-codegen/...
:Checklist:
Further comments
Sorry I'm not familiar with the project structure and if some of these packages are already released with GraphQL16 support. But basically I just took 97ddb48#diff-0162fb12b66d02773262d9cb1ea902dbe2f6c3b429593b772c2fa5d3e8293caf and compared it to output of
yarn changeset