Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add patch GraphQL 16 changeset for packages that were left out #7202

Merged
merged 1 commit into from
Dec 13, 2021

Conversation

jokinol
Copy link
Contributor

@jokinol jokinol commented Dec 13, 2021

🚨 IMPORTANT: Please do not create a Pull Request without creating an issue first.

Any change needs to be discussed before proceeding. Failure to do so may result in the rejection of the pull request.

Description

Added patch changeset for GraphQL16 version bump for packages that were left out in 97ddb48#diff-0162fb12b66d02773262d9cb1ea902dbe2f6c3b429593b772c2fa5d3e8293caf

Related #7003 & #7109

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Screenshots/Sandbox (if appropriate/relevant):

Adding links to sandbox or providing screenshots can help us understand more about this PR and take action on it as appropriate

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Test Environment:

  • OS:
  • @graphql-codegen/...:
  • NodeJS:

Checklist:

  • I have followed the CONTRIBUTING doc and the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Further comments

Sorry I'm not familiar with the project structure and if some of these packages are already released with GraphQL16 support. But basically I just took 97ddb48#diff-0162fb12b66d02773262d9cb1ea902dbe2f6c3b429593b772c2fa5d3e8293caf and compared it to output of yarn changeset

@changeset-bot
Copy link

changeset-bot bot commented Dec 13, 2021

🦋 Changeset detected

Latest commit: 9a5ee07

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 12 packages
Name Type
@graphql-codegen/core Patch
@graphql-codegen/add Patch
@graphql-codegen/fragment-matcher Patch
@graphql-codegen/introspection Patch
@graphql-codegen/time Patch
@graphql-codegen/urql-introspection Patch
@graphql-codegen/typescript-enum-array Patch
@graphql-codegen/typescript-graphql-apollo Patch
@graphql-codegen/typescript-graphql-files-modules Patch
@graphql-codegen/typescript-stencil-apollo Patch
@graphql-codegen/cli Patch
@graphql-cli/codegen Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Dec 13, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/theguild/graphql-code-generator/EesuNctD6AubKaqLFZr53pKs6XYv
✅ Preview: https://graphql-code-generator-git-fork-jokinol-chore-b-be6782-theguild.vercel.app

@jokinol
Copy link
Contributor Author

jokinol commented Dec 13, 2021

Actually I took a different approach for this. I created an empty project with dep "graphql": "16.1.0" and then I tried to install all the packages from graphql-code-generator repository. Got failure with the following commands:

npm add @graphql-codegen/core
npm add @graphql-codegen/add
npm add @graphql-codegen/fragment-matcher
npm add @graphql-codegen/introspection
npm add @graphql-codegen/time
npm add @graphql-codegen/urql-introspection
npm add @graphql-codegen/typescript-enum-array
npm add @graphql-codegen/typescript-graphql-apollo
npm add @graphql-codegen/typescript-graphql-files-modules
npm add @graphql-codegen/named-operations-object
npm add @graphql-codegen/typescript-stencil-apollo

I changed changeset file to reflect my findings and bumped these packages.

I'm not 100% sure if everything is covered but I'm pretty sure that I didn't miss anything. And yes, manual work was included but maybe you can verify missing peerDeps by trying to install those packages.

@n1ru4l n1ru4l merged commit 8643b3b into dotansimha:master Dec 13, 2021
@johnschult
Copy link

@graphql-codegen/typescript got missed... Using version 2.4.2

warning "@graphql-codegen/typescript > @graphql-codegen/visitor-plugin-common > @graphql-tools/relay-operation-optimizer > relay-compiler@12.0.0" has incorrect peer dependency "graphql@^15.0.0".

@dotansimha
Copy link
Owner

@graphql-codegen/typescript got missed... Using version 2.4.2

warning "@graphql-codegen/typescript > @graphql-codegen/visitor-plugin-common > @graphql-tools/relay-operation-optimizer > relay-compiler@12.0.0" has incorrect peer dependency "graphql@^15.0.0".

We didn't miss it, it's an external package that doesn't support graphql v16 yet.
As far as I know, it's only an issue with the peer dependency declaration, and it should still work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants