Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance work: resolvers plugins, documents loading #7452

Merged
merged 5 commits into from
Feb 2, 2022

Conversation

charlypoly
Copy link
Contributor

@charlypoly charlypoly commented Feb 1, 2022

  • skip the type mapping (shouldMapType() calls in createResolversFields()) if not mappers config is provided
  • improve documents loading cache

On a 4sec total build project:

Before
image

After
image

@charlypoly charlypoly self-assigned this Feb 1, 2022
@changeset-bot
Copy link

changeset-bot bot commented Feb 1, 2022

🦋 Changeset detected

Latest commit: d5720f4

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 43 packages
Name Type
@graphql-codegen/cli Patch
@graphql-codegen/visitor-plugin-common Patch
@graphql-cli/codegen Patch
@graphql-codegen/flow Patch
@graphql-codegen/flow-operations Patch
@graphql-codegen/flow-resolvers Patch
@graphql-codegen/java-apollo-android Patch
@graphql-codegen/java-common Patch
@graphql-codegen/java Patch
@graphql-codegen/kotlin Patch
@graphql-codegen/java-resolvers Patch
@graphql-codegen/c-sharp-operations Patch
@graphql-codegen/c-sharp Patch
@graphql-codegen/typescript-apollo-angular Patch
@graphql-codegen/typescript-apollo-client-helpers Patch
@graphql-codegen/typescript-document-nodes Patch
@graphql-codegen/typescript-generic-sdk Patch
@graphql-codegen/gql-tag-operations Patch
@graphql-codegen/typescript-graphql-request Patch
@graphql-codegen/typescript-jit-sdk Patch
@graphql-codegen/typescript-mongodb Patch
@graphql-codegen/typescript-msw Patch
@graphql-codegen/typescript-oclif Patch
@graphql-codegen/typescript-operations Patch
@graphql-codegen/typescript-react-offix Patch
@graphql-codegen/typescript-react-apollo Patch
@graphql-codegen/typescript-react-query Patch
@graphql-codegen/typescript-resolvers Patch
@graphql-codegen/typescript-rtk-query Patch
@graphql-codegen/typescript-stencil-apollo Patch
@graphql-codegen/typescript-type-graphql Patch
@graphql-codegen/typed-document-node Patch
@graphql-codegen/typescript Patch
@graphql-codegen/typescript-urql-graphcache Patch
@graphql-codegen/urql-svelte-operations-store Patch
@graphql-codegen/typescript-urql Patch
@graphql-codegen/typescript-vue-apollo-smart-ops Patch
@graphql-codegen/typescript-vue-apollo Patch
@graphql-codegen/typescript-vue-urql Patch
@graphql-codegen/jsdoc Patch
@graphql-codegen/graphql-modules-preset Patch
@graphql-codegen/import-types-preset Patch
@graphql-codegen/near-operation-file-preset Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Feb 1, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/theguild/graphql-code-generator/7EHBF22hdTJu7VAqnF8uThbT5pCt
✅ Preview: https://graphql-code-generator-git-feat-perf-work-theguild.vercel.app

@theguild-bot
Copy link
Collaborator

theguild-bot commented Feb 1, 2022

The latest changes of this PR are available as alpha in npm (based on the declared changesets):

@graphql-cli/codegen@2.1.8-alpha-5081829d6.0
@graphql-codegen/cli@2.4.1-alpha-5081829d6.0
@graphql-codegen/c-sharp@4.2.3-alpha-5081829d6.0
@graphql-codegen/c-sharp-operations@2.2.3-alpha-5081829d6.0
@graphql-codegen/flow@2.2.3-alpha-5081829d6.0
@graphql-codegen/flow-operations@2.2.3-alpha-5081829d6.0
@graphql-codegen/flow-resolvers@2.2.3-alpha-5081829d6.0
@graphql-codegen/java-apollo-android@2.2.3-alpha-5081829d6.0
@graphql-codegen/java-common@2.1.10-alpha-5081829d6.0
@graphql-codegen/java@3.2.3-alpha-5081829d6.0
@graphql-codegen/kotlin@2.2.3-alpha-5081829d6.0
@graphql-codegen/java-resolvers@2.2.3-alpha-5081829d6.0
@graphql-codegen/jsdoc@2.2.3-alpha-5081829d6.0
@graphql-codegen/visitor-plugin-common@2.5.3-alpha-5081829d6.0
@graphql-codegen/typescript-apollo-angular@3.3.3-alpha-5081829d6.0
@graphql-codegen/typescript-apollo-client-helpers@2.1.10-alpha-5081829d6.0
@graphql-codegen/typescript-document-nodes@2.2.3-alpha-5081829d6.0
@graphql-codegen/typescript-generic-sdk@2.3.2-alpha-5081829d6.0
@graphql-codegen/gql-tag-operations@1.2.6-alpha-5081829d6.0
@graphql-codegen/typescript-graphql-apollo@1.1.2-alpha-5081829d6.0
@graphql-codegen/typescript-graphql-request@4.3.4-alpha-5081829d6.0
@graphql-codegen/typescript-jit-sdk@2.0.1-alpha-5081829d6.0
@graphql-codegen/typescript-mongodb@2.3.1-alpha-5081829d6.0
@graphql-codegen/typescript-msw@1.0.2-alpha-5081829d6.0
@graphql-codegen/typescript-oclif@2.2.3-alpha-5081829d6.0
@graphql-codegen/typescript-operations@2.2.4-alpha-5081829d6.0
@graphql-codegen/typescript-react-apollo@3.2.5-alpha-5081829d6.0
@graphql-codegen/typescript-react-offix@2.2.3-alpha-5081829d6.0
@graphql-codegen/typescript-react-query@3.5.1-alpha-5081829d6.0
@graphql-codegen/typescript-resolvers@2.4.4-alpha-5081829d6.0
@graphql-codegen/typescript-rtk-query@2.2.4-alpha-5081829d6.0
@graphql-codegen/typescript-stencil-apollo@2.2.3-alpha-5081829d6.0
@graphql-codegen/typescript-type-graphql@2.2.4-alpha-5081829d6.0
@graphql-codegen/typed-document-node@2.2.3-alpha-5081829d6.0
@graphql-codegen/typescript@2.4.3-alpha-5081829d6.0
@graphql-codegen/typescript-urql@3.5.1-alpha-5081829d6.0
@graphql-codegen/typescript-urql-graphcache@2.2.4-alpha-5081829d6.0
@graphql-codegen/urql-svelte-operations-store@1.1.10-alpha-5081829d6.0
@graphql-codegen/typescript-vue-apollo@3.2.4-alpha-5081829d6.0
@graphql-codegen/typescript-vue-apollo-smart-ops@2.2.3-alpha-5081829d6.0
@graphql-codegen/typescript-vue-urql@2.2.3-alpha-5081829d6.0
@graphql-codegen/gql-tag-operations-preset@1.2.4-alpha-5081829d6.0
@graphql-codegen/graphql-modules-preset@2.3.3-alpha-5081829d6.0
@graphql-codegen/import-types-preset@2.1.10-alpha-5081829d6.0
@graphql-codegen/near-operation-file-preset@2.2.4-alpha-5081829d6.0

@charlypoly charlypoly marked this pull request as ready for review February 1, 2022 15:10
@dotansimha dotansimha requested review from dotansimha and n1ru4l and removed request for tvvignesh February 1, 2022 15:47
@charlypoly charlypoly merged commit be7cb3a into master Feb 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants