Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: migrate to listr2 #8005

Merged
merged 13 commits into from
Jul 6, 2022
Merged

feat: migrate to listr2 #8005

merged 13 commits into from
Jul 6, 2022

Conversation

saihaj
Copy link
Collaborator

@saihaj saihaj commented Jun 30, 2022 •
edited

See changeset

@changeset-bot
Copy link

changeset-bot bot commented Jun 30, 2022 •
edited

🦋 Changeset detected

Latest commit: 5319f1a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@graphql-codegen/cli Patch
@graphql-cli/codegen Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Jun 30, 2022 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
graphql-code-generator ✅ Ready (Inspect) Visit Preview Jul 6, 2022 at 5:46PM (UTC)

@saihaj saihaj marked this pull request as ready for review July 1, 2022 15:13
@theguild-bot
Copy link
Collaborator

theguild-bot commented Jul 1, 2022 •
edited

The latest changes of this PR are available as alpha in npm (based on the declared changesets):

@graphql-cli/codegen@2.2.7-alpha-9d615db71.0
@graphql-codegen/cli@2.7.1-alpha-9d615db71.0

dotansimha
dotansimha approved these changes Jul 6, 2022
View reviewed changes
Copy link
Owner

@dotansimha dotansimha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rebase and then we are good to go. Thanks @saihaj

@saihaj @n1ru4l
Update .changeset/weak-monkeys-wink.md
4169c22 
Co-authored-by: Laurin Quast <laurinquast@googlemail.com>
@saihaj
Copy link
Collaborator Author

saihaj commented Jul 6, 2022

future task to figure out #8045

@saihaj saihaj merged commit 2e86ecb into master Jul 6, 2022
@saihaj saihaj deleted the saihaj/listr2 branch July 6, 2022 17:58
@Urigo Urigo added this to the CLI Improvements milestone Aug 6, 2022
@vhenzl
Copy link
Contributor

vhenzl commented Sep 26, 2022

This change seems to make the config.errorsOnly option (and the --errors-only CLI flag) unused.

@charlypoly
Copy link
Contributor

charlypoly commented Sep 26, 2022 •
edited

This change seems to make the config.errorsOnly option (and the --errors-only CLI flag) unused.

@vhenzl, you are right, is it an option that you were actively using?

@vhenzl
Copy link
Contributor

vhenzl commented Oct 7, 2022

This change seems to make the config.errorsOnly option (and the --errors-only CLI flag) unused.

@vhenzl, you are right, is it an option that you were actively using?

Nah, I just discovered it when debugging #8382.

@marco2216
Copy link

We are very much missing the --errors-only option. Was it removed on purpose?
Recent issue here #8477

@marco2216 marco2216 mentioned this pull request Oct 26, 2022
Open
@adamperrry
Copy link

Any chance we could get the errorsOnly config option to work again? Watch mode output is really spamming our build script.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@n1ru4l n1ru4l n1ru4l approved these changes

@charlypoly charlypoly Awaiting requested review from charlypoly

@dotansimha dotansimha Awaiting requested review from dotansimha

@ardatan ardatan Awaiting requested review from ardatan

@kamilkisiela kamilkisiela Awaiting requested review from kamilkisiela

Assignees

@saihaj saihaj

Labels
None yet
Projects
None yet
Milestone
CLI Improvements
Development

Successfully merging this pull request may close these issues.

None yet