feat: attach .js extension to all relative/absolute file imports/exports #8034

n1ru4l · 2022-07-05T13:06:17Z

Closes #8022
Closes #8034

changeset-bot · 2022-07-05T13:06:20Z

🦋 Changeset detected

Latest commit: 8eebab3

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 40 packages

Name	Type
@graphql-codegen/visitor-plugin-common	Minor
@graphql-codegen/gql-tag-operations-preset	Minor
@graphql-codegen/near-operation-file-preset	Minor
@graphql-codegen/typescript-oclif	Minor
@graphql-codegen/flow	Patch
@graphql-codegen/flow-operations	Patch
@graphql-codegen/flow-resolvers	Patch
@graphql-codegen/java-apollo-android	Patch
@graphql-codegen/java-common	Patch
@graphql-codegen/java	Patch
@graphql-codegen/kotlin	Patch
@graphql-codegen/java-resolvers	Patch
@graphql-codegen/typescript-apollo-angular	Patch
@graphql-codegen/typescript-apollo-client-helpers	Patch
@graphql-codegen/typescript-document-nodes	Patch
@graphql-codegen/typescript-generic-sdk	Patch
@graphql-codegen/gql-tag-operations	Patch
@graphql-codegen/typescript-graphql-request	Patch
@graphql-codegen/typescript-jit-sdk	Patch
@graphql-codegen/typescript-mongodb	Patch
@graphql-codegen/typescript-msw	Patch
@graphql-codegen/typescript-operations	Patch
@graphql-codegen/typescript-react-offix	Patch
@graphql-codegen/typescript-react-apollo	Patch
@graphql-codegen/typescript-react-query	Patch
@graphql-codegen/typescript-resolvers	Patch
@graphql-codegen/typescript-rtk-query	Patch
@graphql-codegen/typescript-stencil-apollo	Patch
@graphql-codegen/typescript-type-graphql	Patch
@graphql-codegen/typed-document-node	Patch
@graphql-codegen/typescript	Patch
@graphql-codegen/typescript-urql-graphcache	Patch
@graphql-codegen/urql-svelte-operations-store	Patch
@graphql-codegen/typescript-urql	Patch
@graphql-codegen/typescript-vue-apollo-smart-ops	Patch
@graphql-codegen/typescript-vue-apollo	Patch
@graphql-codegen/typescript-vue-urql	Patch
@graphql-codegen/jsdoc	Patch
@graphql-codegen/graphql-modules-preset	Patch
@graphql-codegen/import-types-preset	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

vercel · 2022-07-05T13:06:20Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated
graphql-code-generator	✅ Ready (Inspect)	Visit Preview	Jul 6, 2022 at 1:13PM (UTC)

theguild-bot · 2022-07-05T13:18:06Z

The latest changes of this PR are available as alpha in npm (based on the declared changesets):

@graphql-codegen/c-sharp@4.2.16-alpha-98f983dcf.0
@graphql-codegen/c-sharp-common@0.0.1-alpha-98f983dcf.0
@graphql-codegen/c-sharp-operations@2.2.15-alpha-98f983dcf.0
@graphql-codegen/flow@2.2.15-alpha-98f983dcf.0
@graphql-codegen/flow-operations@2.2.15-alpha-98f983dcf.0
@graphql-codegen/flow-resolvers@2.2.16-alpha-98f983dcf.0
@graphql-codegen/java-apollo-android@2.2.15-alpha-98f983dcf.0
@graphql-codegen/java-common@2.1.22-alpha-98f983dcf.0
@graphql-codegen/java@3.2.16-alpha-98f983dcf.0
@graphql-codegen/kotlin@2.2.16-alpha-98f983dcf.0
@graphql-codegen/java-resolvers@2.2.15-alpha-98f983dcf.0
@graphql-codegen/introspection@2.1.2-alpha-98f983dcf.0
@graphql-codegen/jsdoc@2.2.15-alpha-98f983dcf.0
@graphql-codegen/visitor-plugin-common@2.11.0-alpha-98f983dcf.0
@graphql-codegen/typescript-apollo-angular@3.4.14-alpha-98f983dcf.0
@graphql-codegen/typescript-apollo-client-helpers@2.1.22-alpha-98f983dcf.0
@graphql-codegen/typescript-document-nodes@2.2.15-alpha-98f983dcf.0
@graphql-codegen/typescript-generic-sdk@2.3.14-alpha-98f983dcf.0
@graphql-codegen/gql-tag-operations@1.2.18-alpha-98f983dcf.0
@graphql-codegen/typescript-graphql-apollo@1.1.2-alpha-98f983dcf.0
@graphql-codegen/typescript-graphql-request@4.4.12-alpha-98f983dcf.0
@graphql-codegen/typescript-jit-sdk@2.0.13-alpha-98f983dcf.0
@graphql-codegen/typescript-mongodb@2.3.13-alpha-98f983dcf.0
@graphql-codegen/typescript-msw@1.0.14-alpha-98f983dcf.0
@graphql-codegen/typescript-oclif@2.3.0-alpha-98f983dcf.0
@graphql-codegen/typescript-operations@2.4.4-alpha-98f983dcf.0
@graphql-codegen/typescript-react-apollo@3.2.18-alpha-98f983dcf.0
@graphql-codegen/typescript-react-offix@2.2.15-alpha-98f983dcf.0
@graphql-codegen/typescript-react-query@3.5.16-alpha-98f983dcf.0
@graphql-codegen/typescript-resolvers@2.6.8-alpha-98f983dcf.0
@graphql-codegen/typescript-rtk-query@2.2.16-alpha-98f983dcf.0
@graphql-codegen/typescript-stencil-apollo@2.2.15-alpha-98f983dcf.0
@graphql-codegen/typescript-type-graphql@2.2.16-alpha-98f983dcf.0
@graphql-codegen/typed-document-node@2.2.15-alpha-98f983dcf.0
@graphql-codegen/typescript@2.6.1-alpha-98f983dcf.0
@graphql-codegen/typescript-urql@3.5.14-alpha-98f983dcf.0
@graphql-codegen/typescript-urql-graphcache@2.2.18-alpha-98f983dcf.0
@graphql-codegen/urql-svelte-operations-store@1.1.22-alpha-98f983dcf.0
@graphql-codegen/typescript-vue-apollo@3.2.16-alpha-98f983dcf.0
@graphql-codegen/typescript-vue-apollo-smart-ops@2.2.15-alpha-98f983dcf.0
@graphql-codegen/typescript-vue-urql@2.2.16-alpha-98f983dcf.0
@graphql-codegen/gql-tag-operations-preset@1.5.0-alpha-98f983dcf.0
@graphql-codegen/graphql-modules-preset@2.3.15-alpha-98f983dcf.0
@graphql-codegen/import-types-preset@2.1.22-alpha-98f983dcf.0
@graphql-codegen/near-operation-file-preset@2.3.0-alpha-98f983dcf.0

gilgardosh · 2022-07-06T08:09:22Z

@n1ru4l Is the extension needed here also?

graphql-code-generator/dev-test/gql-tag-operations-urql/gql/gql.d.ts

Lines 7 to 13 in 1479233

    
           ): typeof import('./graphql').FooDocument; 
        
           export function gql( 
        
             source: '\n  fragment Lel on Tweet {\n    id\n    body\n  }\n' 
        
           ): typeof import('./graphql').LelFragmentDoc; 
        
           export function gql( 
        
             source: '\n  query Bar {\n    Tweets {\n      ...Lel\n    }\n  }\n' 
        
           ): typeof import('./graphql').BarDocument;

dev-test/gql-tag-operations/gql/index.ts

…-preset

n1ru4l · 2022-07-06T09:08:12Z

@n1ru4l Is the extension needed here also?

graphql-code-generator/dev-test/gql-tag-operations-urql/gql/gql.d.ts

Lines 7 to 13 in 1479233

): typeof import('./graphql').FooDocument;

export function gql(

source: '\n fragment Lel on Tweet {\n id\n body\n }\n'

): typeof import('./graphql').LelFragmentDoc;

export function gql(

source: '\n query Bar {\n Tweets {\n ...Lel\n }\n }\n'

): typeof import('./graphql').BarDocument;

Good catch, fixed it in 985d167

gilgardosh · 2022-07-06T10:23:12Z

hmm I think extensions should also be added to config inputs, right?

graphql-code-generator/dev-test/codegen.yml

Line 215 in 9a5f31c

importBaseApiFrom: '../../packages/plugins/typescript/rtk-query/tests/baseApi'

otherwise files being generated without it

graphql-code-generator/dev-test/githunt/types.rtk-query.ts

Line 1 in 7649201

    
           import { api } from '../../packages/plugins/typescript/rtk-query/tests/baseApi';

gilgardosh · 2022-07-06T10:29:23Z

this should be rethinked:

graphql-code-generator/packages/presets/graphql-modules/src/index.ts

Line 72 in d84afec

const baseTypesFilename = baseTypesPath.replace(/\.(js|ts|d.ts)$/, '');

extension are removed, for example

graphql-code-generator/dev-test/codegen.yml

Line 360 in 9a5f31c

baseTypesPath: types.ts

resolves into

graphql-code-generator/dev-test/modules/blog/generated.ts

Line 1 in faa1397

import * as Types from '../types';

dotansimha

@n1ru4l do we have any concerns about breaking changes? older TS version or anything like that? (in the generated files, i mean)

gilgardosh · 2022-07-06T10:40:22Z

graphql-code-generator/packages/plugins/typescript/oclif/src/visitor.ts

Line 34 in d84afec

const { handlerPath = '../../handler' } = rawConfig;

default needs extension

gilgardosh · 2022-07-06T10:43:02Z

graphql-code-generator/packages/plugins/typescript/resolvers/tests/ts-resolvers.spec.ts

Line 239 in d84afec

    
           "import { AuthenticatedResolver as ResolverFnAuthenticated } from '../resolver-types.ts';"

also, in this file, look for assurances of ../entities

n1ru4l · 2022-07-06T12:58:32Z

graphql-code-generator/packages/plugins/typescript/resolvers/tests/ts-resolvers.spec.ts

I think this is fine, as it is configured through a user-provided configuration. (

graphql-code-generator/packages/plugins/typescript/resolvers/tests/ts-resolvers.spec.ts

Line 234 in d84afec

authenticated: `../resolver-types.ts#AuthenticatedResolver`,

).

I added a note to the changeset for instructing people to adjust their mappers etc.

n1ru4l · 2022-07-06T12:59:01Z

@n1ru4l do we have any concerns about breaking changes? older TS version or anything like that? (in the generated files, i mean)

.js worked in all previous TS version afaik

n1ru4l · 2022-07-08T23:49:13Z

Apparently, this broke Next.js... #8065

…rts/exports (#8034)" This reverts commit 68bb30e.

…rts/exports" (#8068) * Revert "feat: attach .js extension to all relative/absolute file imports/exports (#8034)" This reverts commit 68bb30e. * chore: add changeset

n1ru4l changed the title ~~fix: attach .js extension to all emitted file imports/exports~~ fix: attach .js extension to all relative file imports/exports Jul 5, 2022

n1ru4l changed the title ~~fix: attach .js extension to all relative file imports/exports~~ fix: attach .js extension to all relative/absolute file imports/exports Jul 5, 2022

vercel bot deployed to Preview July 5, 2022 13:06 View deployment

vercel bot deployed to Preview July 5, 2022 13:22 View deployment

n1ru4l requested review from gilgardosh, dotansimha, kamilkisiela and saihaj and removed request for gilgardosh, dotansimha and kamilkisiela July 5, 2022 13:50

vercel bot deployed to Preview July 5, 2022 13:53 View deployment

n1ru4l changed the title ~~fix: attach .js extension to all relative/absolute file imports/exports~~ feat: attach .js extension to all relative/absolute file imports/exports Jul 5, 2022

gilgardosh reviewed Jul 6, 2022

View reviewed changes

dev-test/gql-tag-operations/gql/index.ts Show resolved Hide resolved

n1ru4l added 5 commits July 6, 2022 10:59

fix: attach .js extension to all gql-tag-operation files

eaf3f31

feat: attach .js extension to all imports generated by near-operation…

752c808

…-preset

chore: add changesets

3d6d4a9

chore: add test for esm import path

a3185e6

fix: attach .js extension for relative import emitted by gql-tag-preset

985d167

n1ru4l force-pushed the feat-esm-imports branch from 2d0d890 to 985d167 Compare July 6, 2022 09:02

n1ru4l requested a review from gilgardosh July 6, 2022 09:07

vercel bot deployed to Preview July 6, 2022 09:08 View deployment

kamilkisiela approved these changes Jul 6, 2022

View reviewed changes

dotansimha reviewed Jul 6, 2022

View reviewed changes

feat: handle oclif plugin

8eebab3

vercel bot deployed to Preview July 6, 2022 13:13 View deployment

saihaj approved these changes Jul 6, 2022

View reviewed changes

saihaj merged commit 68bb30e into master Jul 6, 2022

saihaj deleted the feat-esm-imports branch July 6, 2022 16:33

pix2D mentioned this pull request Jul 8, 2022

near-operation-file + typescript-react-query = Failed to resolve .js import #8065

Closed

n1ru4l added a commit that referenced this pull request Jul 8, 2022

Revert "feat: attach .js extension to all relative/absolute file impo…

6d085da

…rts/exports (#8034)" This reverts commit 68bb30e.

n1ru4l mentioned this pull request Jul 8, 2022

Revert "feat: attach .js extension to all relative/absolute file imports/exports" #8068

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: attach .js extension to all relative/absolute file imports/exports #8034

feat: attach .js extension to all relative/absolute file imports/exports #8034

n1ru4l commented Jul 5, 2022 •

edited

changeset-bot bot commented Jul 5, 2022 •

edited

vercel bot commented Jul 5, 2022 •

edited

theguild-bot commented Jul 5, 2022 •

edited

gilgardosh commented Jul 6, 2022

n1ru4l commented Jul 6, 2022

gilgardosh commented Jul 6, 2022 •

edited

gilgardosh commented Jul 6, 2022

dotansimha left a comment

gilgardosh commented Jul 6, 2022

gilgardosh commented Jul 6, 2022

n1ru4l commented Jul 6, 2022 •

edited

n1ru4l commented Jul 6, 2022

n1ru4l commented Jul 8, 2022

feat: attach .js extension to all relative/absolute file imports/exports #8034

feat: attach .js extension to all relative/absolute file imports/exports #8034

Conversation

n1ru4l commented Jul 5, 2022 • edited

changeset-bot bot commented Jul 5, 2022 • edited

🦋 Changeset detected

vercel bot commented Jul 5, 2022 • edited

theguild-bot commented Jul 5, 2022 • edited

gilgardosh commented Jul 6, 2022

n1ru4l commented Jul 6, 2022

gilgardosh commented Jul 6, 2022 • edited

gilgardosh commented Jul 6, 2022

dotansimha left a comment

Choose a reason for hiding this comment

gilgardosh commented Jul 6, 2022

gilgardosh commented Jul 6, 2022

n1ru4l commented Jul 6, 2022 • edited

n1ru4l commented Jul 6, 2022

n1ru4l commented Jul 8, 2022

n1ru4l commented Jul 5, 2022 •

edited

changeset-bot bot commented Jul 5, 2022 •

edited

vercel bot commented Jul 5, 2022 •

edited

theguild-bot commented Jul 5, 2022 •

edited

gilgardosh commented Jul 6, 2022 •

edited

n1ru4l commented Jul 6, 2022 •

edited