feat: add `emitLegacyCommonJSImports` flag #8077

saihaj · 2022-07-11T17:58:42Z

Description

See changeset

Related #8067

Type of change

Please delete options that are not relevant.

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
This change requires a documentation update

Screenshots/Sandbox (if appropriate/relevant):

Adding links to sandbox or providing screenshots can help us understand more about this PR and take action on it as appropriate

How Has This Been Tested?

Updated dev-tests

Checklist:

I have followed the CONTRIBUTING doc and the style guidelines of this project
I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas
I have made corresponding changes to the documentation
My changes generate no new warnings
I have added tests that prove my fix is effective or that my feature works
New and existing unit tests pass locally with my changes
Any dependent changes have been merged and published in downstream modules

Further comments

Couldn't figure out how to make it work for oclif plugin

changeset-bot · 2022-07-11T17:58:44Z

🦋 Changeset detected

Latest commit: d0d68bc

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 42 packages

Name	Type
@graphql-codegen/cli	Minor
@graphql-codegen/visitor-plugin-common	Minor
@graphql-codegen/gql-tag-operations	Minor
@graphql-codegen/near-operation-file-preset	Minor
@graphql-codegen/plugin-helpers	Minor
@graphql-cli/codegen	Patch
@graphql-codegen/flow	Patch
@graphql-codegen/flow-operations	Patch
@graphql-codegen/flow-resolvers	Patch
@graphql-codegen/java-apollo-android	Patch
@graphql-codegen/java-common	Patch
@graphql-codegen/java	Patch
@graphql-codegen/kotlin	Patch
@graphql-codegen/java-resolvers	Patch
@graphql-codegen/typescript-apollo-angular	Patch
@graphql-codegen/typescript-apollo-client-helpers	Patch
@graphql-codegen/typescript-document-nodes	Patch
@graphql-codegen/typescript-generic-sdk	Patch
@graphql-codegen/typescript-graphql-request	Patch
@graphql-codegen/typescript-jit-sdk	Patch
@graphql-codegen/typescript-mongodb	Patch
@graphql-codegen/typescript-msw	Patch
@graphql-codegen/typescript-oclif	Patch
@graphql-codegen/typescript-operations	Patch
@graphql-codegen/typescript-react-offix	Patch
@graphql-codegen/typescript-react-apollo	Patch
@graphql-codegen/typescript-react-query	Patch
@graphql-codegen/typescript-resolvers	Patch
@graphql-codegen/typescript-rtk-query	Patch
@graphql-codegen/typescript-stencil-apollo	Patch
@graphql-codegen/typescript-type-graphql	Patch
@graphql-codegen/typed-document-node	Patch
@graphql-codegen/typescript	Patch
@graphql-codegen/typescript-urql-graphcache	Patch
@graphql-codegen/urql-svelte-operations-store	Patch
@graphql-codegen/typescript-urql	Patch
@graphql-codegen/typescript-vue-apollo-smart-ops	Patch
@graphql-codegen/typescript-vue-apollo	Patch
@graphql-codegen/typescript-vue-urql	Patch
@graphql-codegen/jsdoc	Patch
@graphql-codegen/graphql-modules-preset	Patch
@graphql-codegen/import-types-preset	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

vercel · 2022-07-11T17:58:44Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated
graphql-code-generator	✅ Ready (Inspect)	Visit Preview	Jul 14, 2022 at 4:27PM (UTC)

theguild-bot · 2022-07-11T18:01:59Z

The latest changes of this PR are available as alpha in npm (based on the declared changesets):

@graphql-cli/codegen@2.3.2-alpha-892ec97e0.0
@graphql-codegen/cli@2.9.0-alpha-892ec97e0.0
@graphql-codegen/core@2.6.1-alpha-892ec97e0.0
@graphql-codegen/c-sharp@4.3.1-alpha-892ec97e0.0
@graphql-codegen/c-sharp-common@0.1.1-alpha-892ec97e0.0
@graphql-codegen/c-sharp-operations@2.3.1-alpha-892ec97e0.0
@graphql-codegen/flow@2.3.2-alpha-892ec97e0.0
@graphql-codegen/flow-operations@2.3.2-alpha-892ec97e0.0
@graphql-codegen/flow-resolvers@2.3.2-alpha-892ec97e0.0
@graphql-codegen/java-apollo-android@2.3.2-alpha-892ec97e0.0
@graphql-codegen/java-common@2.2.2-alpha-892ec97e0.0
@graphql-codegen/java@3.3.2-alpha-892ec97e0.0
@graphql-codegen/kotlin@2.3.2-alpha-892ec97e0.0
@graphql-codegen/java-resolvers@2.3.2-alpha-892ec97e0.0
@graphql-codegen/add@3.2.1-alpha-892ec97e0.0
@graphql-codegen/fragment-matcher@3.3.1-alpha-892ec97e0.0
@graphql-codegen/hasura-allow-list@1.1.1-alpha-892ec97e0.0
@graphql-codegen/introspection@2.2.1-alpha-892ec97e0.0
@graphql-codegen/jsdoc@2.3.2-alpha-892ec97e0.0
@graphql-codegen/schema-ast@2.5.1-alpha-892ec97e0.0
@graphql-codegen/time@3.2.1-alpha-892ec97e0.0
@graphql-codegen/urql-introspection@2.2.1-alpha-892ec97e0.0
@graphql-codegen/visitor-plugin-common@2.12.0-alpha-892ec97e0.0
@graphql-codegen/typescript-apollo-angular@3.5.2-alpha-892ec97e0.0
@graphql-codegen/typescript-apollo-client-helpers@2.2.2-alpha-892ec97e0.0
@graphql-codegen/typescript-document-nodes@2.3.2-alpha-892ec97e0.0
@graphql-codegen/typescript-enum-array@2.2.1-alpha-892ec97e0.0
@graphql-codegen/typescript-generic-sdk@2.4.2-alpha-892ec97e0.0
@graphql-codegen/gql-tag-operations@1.4.0-alpha-892ec97e0.0
@graphql-codegen/typescript-graphql-apollo@1.2.1-alpha-892ec97e0.0
@graphql-codegen/typescript-graphql-files-modules@2.2.1-alpha-892ec97e0.0
@graphql-codegen/typescript-graphql-request@4.5.2-alpha-892ec97e0.0
@graphql-codegen/typescript-jit-sdk@2.1.2-alpha-892ec97e0.0
@graphql-codegen/typescript-mongodb@2.4.2-alpha-892ec97e0.0
@graphql-codegen/typescript-msw@1.1.2-alpha-892ec97e0.0
@graphql-codegen/named-operations-object@2.3.1-alpha-892ec97e0.0
@graphql-codegen/typescript-oclif@2.3.2-alpha-892ec97e0.0
@graphql-codegen/typescript-operations@2.5.2-alpha-892ec97e0.0
@graphql-codegen/typescript-react-apollo@3.3.2-alpha-892ec97e0.0
@graphql-codegen/typescript-react-offix@2.3.2-alpha-892ec97e0.0
@graphql-codegen/typescript-react-query@3.6.2-alpha-892ec97e0.0
@graphql-codegen/typescript-resolvers@2.7.2-alpha-892ec97e0.0
@graphql-codegen/typescript-rtk-query@2.3.2-alpha-892ec97e0.0
@graphql-codegen/typescript-stencil-apollo@2.3.2-alpha-892ec97e0.0
@graphql-codegen/typescript-type-graphql@2.3.2-alpha-892ec97e0.0
@graphql-codegen/typed-document-node@2.3.2-alpha-892ec97e0.0
@graphql-codegen/typescript@2.7.2-alpha-892ec97e0.0
@graphql-codegen/typescript-urql@3.6.2-alpha-892ec97e0.0
@graphql-codegen/typescript-urql-graphcache@2.3.2-alpha-892ec97e0.0
@graphql-codegen/urql-svelte-operations-store@1.2.2-alpha-892ec97e0.0
@graphql-codegen/typescript-vue-apollo@3.3.2-alpha-892ec97e0.0
@graphql-codegen/typescript-vue-apollo-smart-ops@2.3.2-alpha-892ec97e0.0
@graphql-codegen/typescript-vue-urql@2.3.2-alpha-892ec97e0.0
@graphql-codegen/gql-tag-operations-preset@1.5.2-alpha-892ec97e0.0
@graphql-codegen/graphql-modules-preset@2.4.2-alpha-892ec97e0.0
@graphql-codegen/import-types-preset@2.2.2-alpha-892ec97e0.0
@graphql-codegen/near-operation-file-preset@2.4.0-alpha-892ec97e0.0
@graphql-codegen/plugin-helpers@2.6.0-alpha-892ec97e0.0

charlypoly

🦾⚡️

n1ru4l

Can you please resolve the failing tests (update the test fixtures)?

packages/plugins/typescript/gql-tag-operations/src/index.ts

packages/plugins/other/visitor-plugin-common/src/imports.ts

…esets + fix specs Introduced a `shouldEmitLegacyCommonJSImports()` helper to get proper value

packages/presets/near-operation-file/tests/near-operation-file.spec.ts

packages/graphql-codegen-cli/src/config.ts

packages/presets/gql-tag-operations/tests/gql-tag-operations.spec.ts

charlypoly · 2022-07-14T14:28:29Z

Close #8094 is this is merged first

n1ru4l

lfg_emoji.gif

saihaj added 2 commits July 11, 2022 13:51

feat: add emitLegacyCommonJSImports flag

e168507

add changeset

66e1627

saihaj requested review from charlypoly and n1ru4l July 11, 2022 17:58

update docs

f8582ce

charlypoly approved these changes Jul 11, 2022

View reviewed changes

vercel bot deployed to Preview July 11, 2022 18:04 View deployment

fix

4cfc9ac

vercel bot deployed to Preview July 11, 2022 18:28 View deployment

n1ru4l requested changes Jul 12, 2022

View reviewed changes