Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add tslib as dep #8078

Merged
merged 2 commits into from
Jul 11, 2022
Merged

chore: add tslib as dep #8078

merged 2 commits into from
Jul 11, 2022

Conversation

saihaj
Copy link
Collaborator

@saihaj saihaj commented Jul 11, 2022

Description

tslib is used in generated code. In the monorepo it doesn't crash since it uses the one we have in monorepo but we should provide this part of package.

Related #8075

Further comments

Or should we just put this as a peer-dep 🤔

@vercel
Copy link

vercel bot commented Jul 11, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
graphql-code-generator ✅ Ready (Inspect) Visit Preview Jul 11, 2022 at 6:51PM (UTC)

@changeset-bot
Copy link

changeset-bot bot commented Jul 11, 2022

🦋 Changeset detected

Latest commit: 525a496

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@graphql-codegen/cli Patch
@graphql-cli/codegen Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@theguild-bot
Copy link
Collaborator

theguild-bot commented Jul 11, 2022

The latest changes of this PR are available as alpha in npm (based on the declared changesets):

@graphql-cli/codegen@2.3.1-alpha-4a0a50373.0
@graphql-codegen/cli@2.8.1-alpha-4a0a50373.0

Copy link
Collaborator

@n1ru4l n1ru4l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should not pin dependencies

Copy link
Contributor

@charlypoly charlypoly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚡️

@saihaj saihaj merged commit 147e801 into master Jul 11, 2022
@saihaj saihaj deleted the saihaj/8075 branch July 11, 2022 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants