Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(generic-sdk): respect live queries & use AsyncIterable if possible #8204

Merged
merged 2 commits into from
Aug 9, 2022

Conversation

ardatan
Copy link
Collaborator

@ardatan ardatan commented Aug 9, 2022

  • Respect GraphQL Live Queries like Subscriptions and use the stream return types (AsyncIterable or Observable).
  • Previously if there was no usingObservableFrom set in the configuration, the plugin was using Promise as subscriptions' return type, and this is wrong. Now it uses AsyncIterable in this case.

@vercel
Copy link

vercel bot commented Aug 9, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
graphql-code-generator ✅ Ready (Inspect) Visit Preview Aug 9, 2022 at 9:54AM (UTC)

@changeset-bot
Copy link

changeset-bot bot commented Aug 9, 2022

🦋 Changeset detected

Latest commit: 4b1981a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@graphql-codegen/typescript-generic-sdk Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Aug 9, 2022

🚀 Snapshot Release (alpha)

The latest changes of this PR are available as alpha on npm (based on the declared changesets):

Package Version Info
@graphql-codegen/typescript-generic-sdk 3.0.0-alpha-20220809094947-926d246b5 npm ↗︎ unpkg ↗︎

Copy link
Contributor

@charlypoly charlypoly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ardatan, feel free to merge!

@ardatan ardatan merged commit 25a5b0f into master Aug 9, 2022
@ardatan ardatan deleted the sdk-async-iterable branch August 9, 2022 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants